From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0638327CB02; Tue, 16 Dec 2025 12:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765887599; cv=none; b=eEwH6EsZXafvBM5TXIu4T6POeuIJe2UNNFKAaLfZdcEyr58cNjH1FK2mWvSmp7hmTQbiOZCfZX9sI/BbtVJkq2FV3v/qzrXDVfgDsihAGBd8GWih/INuC+3CroB1wW3tC7soeJOgp/bks+93z/crbMHZZqMCeftcZjAhJjpka2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765887599; c=relaxed/simple; bh=4vfukD3qvRrC/gUttR9UIN9rnWCTIa9XKZ/G9280VPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pCuL4Kjs7eGCKE05c9uSt4nFowuk8lcGIkh7AkhKXCwxF7P/7ARsRv6yKJt/ywCCBoe7RmynCcgGIZ2MvfuNzTQBHRn1Bik0LmKsOi7pZakPbSGv19w50NrLD79py2CVK+9e2pGTnBnYTQYyUdHCKpbSDqT62gS6/NFr/45/wQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yq56LxFF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yq56LxFF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DE13C4CEF5; Tue, 16 Dec 2025 12:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765887598; bh=4vfukD3qvRrC/gUttR9UIN9rnWCTIa9XKZ/G9280VPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yq56LxFFEVm32UfGw1/GanHuUNCaZ31+aK5qBCDgf+yH4NwdyODLNfPtD+IUlO3YX IPOuRvnfF+k3c7TP8+b576N8y+lv8oz4A58iSKvQahoJLXlE86X90pr9dOb0FnJgx3 YO609zlIq6cHFd0hCQq2diSMUz+saxfEzOg9ilyM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdun Nihaal , Johannes Berg , Sasha Levin Subject: [PATCH 6.18 247/614] wifi: cw1200: Fix potential memory leak in cw1200_bh_rx_helper() Date: Tue, 16 Dec 2025 12:10:14 +0100 Message-ID: <20251216111410.323424320@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111401.280873349@linuxfoundation.org> References: <20251216111401.280873349@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdun Nihaal [ Upstream commit 5e88e864118c20e63a1571d0ff0a152e5d684959 ] In one of the error paths, the memory allocated for skb_rx is not freed. Fix that by freeing it before returning. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Signed-off-by: Abdun Nihaal Link: https://patch.msgid.link/20251110175316.106591-1-nihaal@cse.iitm.ac.in Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/st/cw1200/bh.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/bh.c b/drivers/net/wireless/st/cw1200/bh.c index 3b4ded2ac801c..37232ee220375 100644 --- a/drivers/net/wireless/st/cw1200/bh.c +++ b/drivers/net/wireless/st/cw1200/bh.c @@ -317,10 +317,12 @@ static int cw1200_bh_rx_helper(struct cw1200_common *priv, if (wsm_id & 0x0400) { int rc = wsm_release_tx_buffer(priv, 1); - if (WARN_ON(rc < 0)) + if (WARN_ON(rc < 0)) { + dev_kfree_skb(skb_rx); return rc; - else if (rc > 0) + } else if (rc > 0) { *tx = 1; + } } /* cw1200_wsm_rx takes care on SKB livetime */ -- 2.51.0