From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22CA939BEA3; Tue, 16 Dec 2025 12:38:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888688; cv=none; b=igguWUjNhmqOSLdWspyu+LGTslcwHydwuRzJNCSVwNa/gn+Gt3I6AdpeO8r6IH9IchiJ9aUmp0iRExCST0ma9QciA78TqBz0U0IxGHYzTUdGRGWgmuZZLDS2RdBfje7E9ur6y+bQgtgfNrj0CuyyVPMVE/ItwDkKeGgbF3qomvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765888688; c=relaxed/simple; bh=/KCA5SoRgNL3w26AVHoqUYlm7QJFr7/Yg2HVUs9gEk4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mfM/Erpwh+iWnttvt2gROaoEEnL/yCBXtXxgVX3OJU25Bllr+tzWa0AeMXUpE7U7y68SrUVgyI73MFK/M9U1Cyg5zsRmB01cbdhg92MP1Hfw8HfG1Pda7frQ7AhUSRr0R8DsWKfS1FABBae/YD4t/Mqu8c6J37CmILZNHO5Kxt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2wawq8RN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2wawq8RN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A690BC4CEF1; Tue, 16 Dec 2025 12:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765888688; bh=/KCA5SoRgNL3w26AVHoqUYlm7QJFr7/Yg2HVUs9gEk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2wawq8RN2paLfkyq/ZuEfpRf5/qZy2MPvGlz7mEM5BnF2W+URUw+excixgBAsOYdr IwabS6iWIQ5+eJNEduiRAhAzVc8DMMdUpGNEPLStf99ti4N9U0TqUvM+69aEcyRPEz FIRH+UL0pElqXcyAwz9xGU7vC5Ocu9VJdx7bBANc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Junrui Luo , Takashi Sakamoto , Takashi Iwai Subject: [PATCH 6.18 609/614] ALSA: dice: fix buffer overflow in detect_stream_formats() Date: Tue, 16 Dec 2025 12:16:16 +0100 Message-ID: <20251216111423.461011050@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111401.280873349@linuxfoundation.org> References: <20251216111401.280873349@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo commit 324f3e03e8a85931ce0880654e3c3eb38b0f0bba upstream. The function detect_stream_formats() reads the stream_count value directly from a FireWire device without validating it. This can lead to out-of-bounds writes when a malicious device provides a stream_count value greater than MAX_STREAMS. Fix by applying the same validation to both TX and RX stream counts in detect_stream_formats(). Reported-by: Yuhao Jiang Reported-by: Junrui Luo Fixes: 58579c056c1c ("ALSA: dice: use extended protocol to detect available stream formats") Cc: stable@vger.kernel.org Reviewed-by: Takashi Sakamoto Signed-off-by: Junrui Luo Link: https://patch.msgid.link/SYBPR01MB7881B043FC68B4C0DA40B73DAFDCA@SYBPR01MB7881.ausprd01.prod.outlook.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/dice/dice-extension.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/firewire/dice/dice-extension.c +++ b/sound/firewire/dice/dice-extension.c @@ -116,7 +116,7 @@ static int detect_stream_formats(struct break; base_offset += EXT_APP_STREAM_ENTRIES; - stream_count = be32_to_cpu(reg[0]); + stream_count = min_t(unsigned int, be32_to_cpu(reg[0]), MAX_STREAMS); err = read_stream_entries(dice, section_addr, base_offset, stream_count, mode, dice->tx_pcm_chs, @@ -125,7 +125,7 @@ static int detect_stream_formats(struct break; base_offset += stream_count * EXT_APP_STREAM_ENTRY_SIZE; - stream_count = be32_to_cpu(reg[1]); + stream_count = min_t(unsigned int, be32_to_cpu(reg[1]), MAX_STREAMS); err = read_stream_entries(dice, section_addr, base_offset, stream_count, mode, dice->rx_pcm_chs,