Re: [PATCH] PNP: add put_device() in pnpbios_init()

[kernel test robot <lkp@intel.com>]

Hi Haoxiang,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.19-rc1 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Haoxiang-Li/PNP-add-put_device-in-pnpbios_init/20251218-162345
base:   linus/master
patch link:    https://lore.kernel.org/r/20251218081955.548521-1-lihaoxiang%40isrc.iscas.ac.cn
patch subject: [PATCH] PNP: add put_device() in pnpbios_init()
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20251221/202512210401.KjSlGMtG-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251221/202512210401.KjSlGMtG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512210401.KjSlGMtG-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/pnp/pnpbios/core.c: In function 'pnp_dock_event':
   drivers/pnp/pnpbios/core.c:90:20: warning: variable 'value' set but not used [-Wunused-but-set-variable]
      90 |         int i = 0, value;
         |                    ^~~~~
   In file included from include/asm-generic/bug.h:31,
                    from arch/x86/include/asm/bug.h:193,
                    from arch/x86/include/asm/alternative.h:9,
                    from arch/x86/include/asm/barrier.h:5,
                    from include/asm-generic/bitops/generic-non-atomic.h:7,
                    from include/linux/bitops.h:28,
                    from include/linux/kernel.h:23,
                    from drivers/pnp/pnpbios/core.c:38:
   drivers/pnp/pnpbios/core.c: In function 'pnpbios_init':
>> include/linux/printk.h:482:10: error: expected expression before '{' token
     482 |         ({                                                              \
         |          ^
   include/linux/printk.h:512:26: note: in expansion of macro 'printk_index_wrap'
     512 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                          ^~~~~~~~~~~~~~~~~
   drivers/pnp/pnpbios/core.c:542:17: note: in expansion of macro 'printk'
     542 |                 printk(KERN_ERR
         |                 ^~~~~~
>> drivers/pnp/pnpbios/core.c:541:17: error: called object is not a function or function pointer
     541 |                 put_device(&pnpbios_protocol.dev)
         |                 ^~~~~~~~~~


vim +541 drivers/pnp/pnpbios/core.c

   522	
   523		/* scan the system for pnpbios support */
   524		if (!pnpbios_probe_system())
   525			return -ENODEV;
   526	
   527		/* make preparations for bios calls */
   528		pnpbios_calls_init(pnp_bios_install);
   529	
   530		/* read the node info */
   531		ret = pnp_bios_dev_node_info(&node_info);
   532		if (ret) {
   533			printk(KERN_ERR
   534			       "PnPBIOS: Unable to get node info.  Aborting.\n");
   535			return ret;
   536		}
   537	
   538		/* register with the pnp layer */
   539		ret = pnp_register_protocol(&pnpbios_protocol);
   540		if (ret) {
 > 541			put_device(&pnpbios_protocol.dev)
   542			printk(KERN_ERR
   543			       "PnPBIOS: Unable to register driver.  Aborting.\n");
   544			return ret;
   545		}
   546	
   547		/* start the proc interface */
   548		ret = pnpbios_proc_init();
   549		if (ret)
   550			printk(KERN_ERR "PnPBIOS: Failed to create proc interface.\n");
   551	
   552		/* scan for pnpbios devices */
   553		build_devlist();
   554	
   555		pnp_platform_devices = 1;
   556		return 0;
   557	}
   558	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki