From: Greg KH <gregkh@linuxfoundation.org>
To: Chanho Min <chanho.min@lge.com>
Cc: Oscar Maes <oscmaes92@gmail.com>,
stable@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] net: ipv4: fix regression in local-broadcast routes
Date: Tue, 23 Dec 2025 08:44:32 +0100 [thread overview]
Message-ID: <2025122311-animating-lettuce-ed6a@gregkh> (raw)
In-Reply-To: <20251223065911.11660-1-chanho.min@lge.com>
On Tue, Dec 23, 2025 at 03:59:11PM +0900, Chanho Min wrote:
> From: Oscar Maes <oscmaes92@gmail.com>
>
> [ Upstream commit 5189446ba995556eaa3755a6e875bc06675b88bd ]
>
> Commit 9e30ecf23b1b ("net: ipv4: fix incorrect MTU in broadcast routes")
> introduced a regression where local-broadcast packets would have their
> gateway set in __mkroute_output, which was caused by fi = NULL being
> removed.
>
> Fix this by resetting the fib_info for local-broadcast packets. This
> preserves the intended changes for directed-broadcast packets.
>
> Cc: stable@vger.kernel.org
> Fixes: 9e30ecf23b1b ("net: ipv4: fix incorrect MTU in broadcast routes")
> Reported-by: Brett A C Sheffield <bacs@librecast.net>
> Closes: https://lore.kernel.org/regressions/20250822165231.4353-4-bacs@librecast.net
> Signed-off-by: Oscar Maes <oscmaes92@gmail.com>
> Reviewed-by: David Ahern <dsahern@kernel.org>
> Link: https://patch.msgid.link/20250827062322.4807-1-oscmaes92@gmail.com
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> net/ipv4/route.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
You forgot to sign off on this :(
Also, what tree do you want this backported to?
thanks,
greg k-h
next prev parent reply other threads:[~2025-12-23 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 6:59 [PATCH] net: ipv4: fix regression in local-broadcast routes Chanho Min
2025-12-23 7:09 ` 민찬호/책임연구원/SW Platform(연)Advanced OS TP
2025-12-23 7:44 ` Greg KH [this message]
2025-12-23 8:09 ` Chanho Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025122311-animating-lettuce-ed6a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chanho.min@lge.com \
--cc=oscmaes92@gmail.com \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox