From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88BB82356A4 for ; Mon, 5 Jan 2026 14:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767623792; cv=none; b=daJt5f3tFQbWQ1575sa6uGikAyzeCkc+4toqj1LHSR1zvBd037TkYWjYsulBJnWoUqEsyccMEcWkYFYYIuvdR5/6UCOeMnV0zk/kTESs9Z0oJ9kS0C4Z0HDBDImwhK2J/2NM3LLhWj/z+DRxPlylkW1moxfEvQ+prXebuUXiiJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767623792; c=relaxed/simple; bh=yZeJGuzYEubGRrUlK9K7uAb2yzaLERhdi8nxaF4AqBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r/tBEKQnBHt78xYlfehP7cSD7TAOFE/gm53lA1P3TESXro+TxULMp8qqbUhURYbE2tpjUr1/pJ8nkrMBQok4t4H1ets6DeaS1MjKxaY0WLQ1X4roFTYIaq3Pnlqzz+DwwsmEo14kJh0D3N7tCcUh6AQ3Omt31QzScQj+w+0eSnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ABBxw478; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ABBxw478" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 793E9C116D0; Mon, 5 Jan 2026 14:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767623791; bh=yZeJGuzYEubGRrUlK9K7uAb2yzaLERhdi8nxaF4AqBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ABBxw478ak+1JEYK94bodwsmaOpbl5+2yOCfLstKPAEp/sx0ElIh8y5DH8O6DxTsH WNIIsv7F0s2X88R/7oACo0DgTo2cniIVCeg8K75yWWMi4Qqr8gme4PD7DcOkgsCIPR 9rXpKvsWj6q+UgzNehkbKXdaya4/ujCndEvN5H/I7mvhNct4I3X9K4QKg5/PnKRMN3 5uSHd12WKfNbTeDEMNtAZiLvNteMWdyE1gHLZ2bzB5fiygwOk3/4WXzqUoB84Iy2Mh mjBO9wXu+q1n2v9RTWBP0P0EOE93Lu42cXhOoQcnSZmWtUMuqI67XKkUxILpOoiCIz ij0hxGoFF3cCg== From: Sasha Levin To: stable@vger.kernel.org Cc: Johan Hovold , Olivier Moysan , olivier moysan , Mark Brown , Sasha Levin Subject: [PATCH 5.10.y 3/3] ASoC: stm32: sai: fix clk prepare imbalance on probe failure Date: Mon, 5 Jan 2026 09:36:26 -0500 Message-ID: <20260105143626.2605607-3-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260105143626.2605607-1-sashal@kernel.org> References: <2026010531-relapse-parcel-11e0@gregkh> <20260105143626.2605607-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Johan Hovold [ Upstream commit 312ec2f0d9d1a5656f76d770bbf1d967e9289aa7 ] Make sure to unprepare the parent clock also on probe failures (e.g. probe deferral). Fixes: a14bf98c045b ("ASoC: stm32: sai: fix possible circular locking") Cc: stable@vger.kernel.org # 5.5 Cc: Olivier Moysan Signed-off-by: Johan Hovold Reviewed-by: olivier moysan Link: https://patch.msgid.link/20251124104908.15754-3-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/stm/stm32_sai_sub.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 1ea083725655..1810c43d0833 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -1485,14 +1485,21 @@ static int stm32_sai_sub_parse_of(struct platform_device *pdev, if (of_find_property(np, "#clock-cells", NULL)) { ret = stm32_sai_add_mclk_provider(sai); if (ret < 0) - return ret; + goto err_unprepare_pclk; } else { sai->sai_mclk = devm_clk_get_optional(&pdev->dev, "MCLK"); - if (IS_ERR(sai->sai_mclk)) - return PTR_ERR(sai->sai_mclk); + if (IS_ERR(sai->sai_mclk)) { + ret = PTR_ERR(sai->sai_mclk); + goto err_unprepare_pclk; + } } return 0; + +err_unprepare_pclk: + clk_unprepare(sai->pdata->pclk); + + return ret; } static int stm32_sai_sub_probe(struct platform_device *pdev) @@ -1536,26 +1543,33 @@ static int stm32_sai_sub_probe(struct platform_device *pdev) IRQF_SHARED, dev_name(&pdev->dev), sai); if (ret) { dev_err(&pdev->dev, "IRQ request returned %d\n", ret); - return ret; + goto err_unprepare_pclk; } if (STM_SAI_PROTOCOL_IS_SPDIF(sai)) conf = &stm32_sai_pcm_config_spdif; ret = snd_dmaengine_pcm_register(&pdev->dev, conf, 0); - if (ret) - return dev_err_probe(&pdev->dev, ret, "Could not register pcm dma\n"); + if (ret) { + ret = dev_err_probe(&pdev->dev, ret, "Could not register pcm dma\n"); + goto err_unprepare_pclk; + } ret = snd_soc_register_component(&pdev->dev, &stm32_component, &sai->cpu_dai_drv, 1); if (ret) { snd_dmaengine_pcm_unregister(&pdev->dev); - return ret; + goto err_unprepare_pclk; } pm_runtime_enable(&pdev->dev); return 0; + +err_unprepare_pclk: + clk_unprepare(sai->pdata->pclk); + + return ret; } static int stm32_sai_sub_remove(struct platform_device *pdev) -- 2.51.0