From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF34630F951 for ; Mon, 5 Jan 2026 19:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767642065; cv=none; b=hBhi3FZBDnewv+25586Cl0usoNpwxxp1iTJvWuKcUu7G3ObgfdcR0yAI2EC/uyYR4bfBEPODDLGtEaDJFzoKivJFq+5WBgM5X3wrKtOLFYbPtOszblvldMjUdjrBMHHSN83STbEORqBv5lzuOiPfPvnXczyLLWl5+fG31ATqO8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767642065; c=relaxed/simple; bh=R2yY2xdMzzfEAOOMS28dL7b9p7PbkdoF0QzWepdx5FM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V/QrIT3OF7wdu8y/G7YyfAMsqzeesrC2o1+0YKLkru6mLE5AItyN17+U8GXkOsN1ZRPuTbepoYu/EuBKUbl+752d/xq6CYpUCUvRsOSYcA7DSxnRr+Gk43C/qFzqORMNXanA2YIRbecIfAJ6qTYCIh/XC3HQR8RowYq9xszLLmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fLAyjBNi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fLAyjBNi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2495C19422; Mon, 5 Jan 2026 19:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767642065; bh=R2yY2xdMzzfEAOOMS28dL7b9p7PbkdoF0QzWepdx5FM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fLAyjBNi+TsB6fnaA/+5i2lmSWezTJZ7TJ4jm14KGuSXY3hJO+SPOZ0DI2+jKoYzy dsBaSS/PRJyDF40+0P267lk7Qt8Xw3La0yyvYoPCqwEQRZ2kPjRpB257MZ7G2QjCrd SFswPexroXZf5CyHfuwxexgurDbj3KJGCAMFMlIH1snW0QzshOKxb+uHvxNuD0y5Je nLctiCOAiUey5vXGR9PKHhOL0G+VkH2OTK6W0mmRpfG/OX3Q5LzYI32JyzXDSxFRbs 8x0Uy4ebAQ0+cggFC81ZoDUmka7z5Rn+G0y9eo7R911+JYNojT9KXd57CQ/MN0+xeQ Otp4lbeh8DQGQ== From: Sasha Levin To: stable@vger.kernel.org Cc: David Hildenbrand , Zi Yan , Lorenzo Stoakes , Alistair Popple , Al Viro , Arnd Bergmann , Brendan Jackman , Byungchul Park , Chengming Zhou , Christian Brauner , Christophe Leroy , =?UTF-8?q?Eugenio=20P=C3=A9=20rez?= , Greg Kroah-Hartman , Gregory Price , "Huang, Ying" , Jan Kara , Jason Gunthorpe , Jason Wang , Jerrin Shaji George , Johannes Weiner , John Hubbard , Jonathan Corbet , Joshua Hahn , Liam Howlett , Madhavan Srinivasan , Mathew Brost , "Matthew Wilcox (Oracle)" , Miaohe Lin , Michael Ellerman , "Michael S. Tsirkin" , Michal Hocko , Mike Rapoport , Minchan Kim , Naoya Horiguchi , Nicholas Piggin , Oscar Salvador , Peter Xu , Qi Zheng , Rakie Kim , Rik van Riel , Sergey Senozhatsky , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Xuan Zhuo , xu xin , Harry Yoo , Andrew Morton , Sasha Levin Subject: [PATCH 5.10.y 2/4] mm/balloon_compaction: we cannot have isolated pages in the balloon list Date: Mon, 5 Jan 2026 14:40:55 -0500 Message-ID: <20260105194057.2747929-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260105194057.2747929-1-sashal@kernel.org> References: <2026010548-hacked-transfer-1f00@gregkh> <20260105194057.2747929-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: David Hildenbrand [ Upstream commit fb05f992b6bbb4702307d96f00703ee637b24dbf ] Patch series "mm/migration: rework movable_ops page migration (part 1)", v2. In the future, as we decouple "struct page" from "struct folio", pages that support "non-lru page migration" -- movable_ops page migration such as memory balloons and zsmalloc -- will no longer be folios. They will not have ->mapping, ->lru, and likely no refcount and no page lock. But they will have a type and flags 🙂 This is the first part (other parts not written yet) of decoupling movable_ops page migration from folio migration. In this series, we get rid of the ->mapping usage, and start cleaning up the code + separating it from folio migration. Migration core will have to be further reworked to not treat movable_ops pages like folios. This is the first step into that direction. This patch (of 29): The core will set PG_isolated only after mops->isolate_page() was called. In case of the balloon, that is where we will remove it from the balloon list. So we cannot have isolated pages in the balloon list. Let's drop this unnecessary check. Link: https://lkml.kernel.org/r/20250704102524.326966-2-david@redhat.com Signed-off-by: David Hildenbrand Acked-by: Zi Yan Reviewed-by: Lorenzo Stoakes Cc: Alistair Popple Cc: Al Viro Cc: Arnd Bergmann Cc: Brendan Jackman Cc: Byungchul Park Cc: Chengming Zhou Cc: Christian Brauner Cc: Christophe Leroy Cc: Eugenio Pé rez Cc: Greg Kroah-Hartman Cc: Gregory Price Cc: "Huang, Ying" Cc: Jan Kara Cc: Jason Gunthorpe Cc: Jason Wang Cc: Jerrin Shaji George Cc: Johannes Weiner Cc: John Hubbard Cc: Jonathan Corbet Cc: Joshua Hahn Cc: Liam Howlett Cc: Madhavan Srinivasan Cc: Mathew Brost Cc: Matthew Wilcox (Oracle) Cc: Miaohe Lin Cc: Michael Ellerman Cc: "Michael S. Tsirkin" Cc: Michal Hocko Cc: Mike Rapoport Cc: Minchan Kim Cc: Naoya Horiguchi Cc: Nicholas Piggin Cc: Oscar Salvador Cc: Peter Xu Cc: Qi Zheng Cc: Rakie Kim Cc: Rik van Riel Cc: Sergey Senozhatsky Cc: Shakeel Butt Cc: Suren Baghdasaryan Cc: Vlastimil Babka Cc: Xuan Zhuo Cc: xu xin Cc: Harry Yoo Signed-off-by: Andrew Morton Stable-dep-of: 0da2ba35c0d5 ("powerpc/pseries/cmm: adjust BALLOON_MIGRATE when migrating pages") Signed-off-by: Sasha Levin --- mm/balloon_compaction.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 829874221410..02bcc22a6e77 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -93,12 +93,6 @@ size_t balloon_page_list_dequeue(struct balloon_dev_info *b_dev_info, if (!trylock_page(page)) continue; - if (IS_ENABLED(CONFIG_BALLOON_COMPACTION) && - PageIsolated(page)) { - /* raced with isolation */ - unlock_page(page); - continue; - } balloon_page_delete(page); __count_vm_event(BALLOON_DEFLATE); list_add(&page->lru, pages); -- 2.51.0