public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
	sashal@kernel.org, Marko Turk <mt@markoturk.info>,
	Dirk Behme <dirk.behme@gmail.com>,
	dirk.behme@de.bosch.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment
Date: Mon, 5 Jan 2026 07:25:51 +0100	[thread overview]
Message-ID: <2026010520-quickness-humble-70db@gregkh> (raw)
In-Reply-To: <CANiq72=fFZpWJ9BvHEBqi4chZO3rFo8+-F9=myW1f_JzJ0PNrg@mail.gmail.com>

On Sun, Jan 04, 2026 at 07:30:22PM +0100, Miguel Ojeda wrote:
> On Sun, Jan 4, 2026 at 3:08 PM Danilo Krummrich <dakr@kernel.org> wrote:
> >
> > In general I prefer to only add a Fixes: tag for the commit that introduced the
> > issue.
> 
> If their scripts track moves well, then it is great to avoid it, but I
> am not sure how well that works or not or in which cases, i.e. it
> could look like two different commits introduced the issue and thus
> one backport could be missed. Not sure.
> 
> > Again, I could also remember this wrongly, but I think I just recently reviewed
> > such a commit from Sasha. :)
> 
> Hmm... I also had a few cases where Sasha autoapplied, but in most
> cases, I had to provide custom patches when they didn't apply cleanly,
> even trivial ones.

It all depends, sometimes we can handle file moves easily, sometimes we
can not.

But really, why is a comment typo being needed in stable kernels?

thanks,

greg k-h

  reply	other threads:[~2026-01-05  6:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260103143119.96095-1-mt@markoturk.info>
     [not found] ` <20260103143119.96095-2-mt@markoturk.info>
     [not found]   ` <DFF23OTZRIDS.2PZIV7D8AHWFA@kernel.org>
     [not found]     ` <84cc5699-f9ab-42b3-a1ea-15bf9bd80d19@gmail.com>
     [not found]       ` <aVmHGBop5OPlVVBa@vps.markoturk.info>
     [not found]         ` <CANiq72=t-U8JTH2JZxkQaW7sbYXjWLpkYkuMd_CuzLoJLbEvgQ@mail.gmail.com>
2026-01-04 14:08           ` [PATCH 2/2] rust: pci: fix typo in Bar struct's comment Danilo Krummrich
2026-01-04 18:30             ` Miguel Ojeda
2026-01-05  6:25               ` Greg KH [this message]
2026-01-05 10:39                 ` Miguel Ojeda
2026-01-05 12:38                   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026010520-quickness-humble-70db@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dakr@kernel.org \
    --cc=dirk.behme@de.bosch.com \
    --cc=dirk.behme@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mt@markoturk.info \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox