From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 337EC2BCF5; Mon, 5 Jan 2026 06:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767594355; cv=none; b=LSc5TkjOK+hrNEJhQPCQ5t6eV3+L6b/eYykU3I4w6kZzkk8uFsKhDtWwq4XVukbEWuweNzFJjWHOKndqE3/FRw3XEih3Gop8AHCV0ICJZNh2XAlpMSwVVvMQ89k+va3CI3/VZnURgjQL3aLiFP2b5PYaeEcmHQELMBExIAeqF6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767594355; c=relaxed/simple; bh=znNJncmbBCy4v0V/A8ag6P3qRxQ8kYYT08leohhSGkA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=af9pFzOa80zzogDiyTKuiwcAkNmObwbdyfl38imF6Gcx5vFnKfPf7nYoNzssW3fA6JVC4HT04L5m6XH6EUktGu4CeOc6ZjJxS4cs00951bXHLSf3C2NV3vpTweiXDtPRGU7QwHxBGM89Dyib0ziZ+uY6+hgK9s6J7gpNaGsBedA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y1+zCqp/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y1+zCqp/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5814FC116D0; Mon, 5 Jan 2026 06:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767594354; bh=znNJncmbBCy4v0V/A8ag6P3qRxQ8kYYT08leohhSGkA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y1+zCqp/19qYNFp+skjNYUN8hzfo5VdLs6lyi4GRjKzIGzsNHMcVYWGJPsQ5FS4fK nB8f7w01P7OQm20CoPEIqRRafUQP0TF2FrCEwpavzb9KxVodgUK3dD/WIOxBFF5vrR dMVBjnHnGxZcP/9MKsdTGN3ZU4lAPo6pnecpH3u4= Date: Mon, 5 Jan 2026 07:25:51 +0100 From: Greg KH To: Miguel Ojeda Cc: Danilo Krummrich , sashal@kernel.org, Marko Turk , Dirk Behme , dirk.behme@de.bosch.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment Message-ID: <2026010520-quickness-humble-70db@gregkh> References: <20260103143119.96095-1-mt@markoturk.info> <20260103143119.96095-2-mt@markoturk.info> <84cc5699-f9ab-42b3-a1ea-15bf9bd80d19@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Jan 04, 2026 at 07:30:22PM +0100, Miguel Ojeda wrote: > On Sun, Jan 4, 2026 at 3:08 PM Danilo Krummrich wrote: > > > > In general I prefer to only add a Fixes: tag for the commit that introduced the > > issue. > > If their scripts track moves well, then it is great to avoid it, but I > am not sure how well that works or not or in which cases, i.e. it > could look like two different commits introduced the issue and thus > one backport could be missed. Not sure. > > > Again, I could also remember this wrongly, but I think I just recently reviewed > > such a commit from Sasha. :) > > Hmm... I also had a few cases where Sasha autoapplied, but in most > cases, I had to provide custom patches when they didn't apply cleanly, > even trivial ones. It all depends, sometimes we can handle file moves easily, sometimes we can not. But really, why is a comment typo being needed in stable kernels? thanks, greg k-h