From: Nathan Chancellor <nathan@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Siddhesh Poyarekar <siddhesh@gotplt.org>,
Nicolas Schier <nsc@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
rust-for-linux@vger.kernel.org, Kees Cook <kees@kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
stable@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>
Subject: Re: [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags
Date: Mon, 5 Jan 2026 16:03:22 -0700 [thread overview]
Message-ID: <20260105230322.GA1276749@ax162> (raw)
In-Reply-To: <CANiq72n0BtCxAsXOaNnSMWC-aW2bNTPzN=4VGb+ic8YA6jhsAw@mail.gmail.com>
On Sun, Jan 04, 2026 at 09:53:25PM +0100, Miguel Ojeda wrote:
> On Wed, Dec 17, 2025 at 11:41 PM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
> >
> > but clang does not have this option, so avoid passing it to bindgen.
>
> This looks indeed correct, although it is not yet in a released GCC
> (testing quickly in Compiler Explorer, GCC 15.2 doesn't have it, but
> GCC trunk has).
>
> I will apply it -- Cc'ing ClangBuiltLinux and Kbuild so that they are aware.
Right, this does look correct, as this option is specific to GCC for the
purpose of exposing more information from GCC internals to the user for
understanding diagnostics better.
I will say if this makes 6.19, the stable tag is not necessary since
7454048db27d6 landed in 6.19-rc1 and I would not expect it to get
backported (but even if it did via AUTOSEL or something, the Fixes tag
should ensure it gets included).
Cheers,
Nathan
next prev parent reply other threads:[~2026-01-05 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251217150010.665153-1-siddhesh@gotplt.org>
2025-12-17 22:40 ` [PATCH v2] rust: Add -fdiagnostics-show-context to bindgen_skip_c_flags Siddhesh Poyarekar
2026-01-04 20:53 ` Miguel Ojeda
2026-01-05 10:58 ` Siddhesh Poyarekar
2026-01-05 23:03 ` Nathan Chancellor [this message]
2026-01-06 20:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105230322.GA1276749@ax162 \
--to=nathan@kernel.org \
--cc=aliceryhl@google.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=siddhesh@gotplt.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox