From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64931FE46D; Tue, 6 Jan 2026 01:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767664096; cv=none; b=THblxLFfwWI3jKNFbC6YiGv4vNYD661Xgausiv5bZkhNWdbJ8Vf69D1s5RBpHS8MdFHoCW6rsVQyA4Qs9dfy/FWbw1az/UrBEKT8edj+Glp3xppX/Dh0PCcmusIprnjdyt5yd65E1cVM1B8j8QjMwb1VEC8bj3WmEl2Z+CftkiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767664096; c=relaxed/simple; bh=gWgwY5gnqLtgEV6SUiR41ffmkBcPFEdij50nSL0+hes=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k/Ej6b1sOE6t5RzX9G2o3PJGLYZ1XVo+qUfH7igvEevS25FrX6C8F4EhfitfTFoy6LZuyzEmrCPdy+0sHF144gUKvd0e0aIKpE1iPx5VLPHrdGsLkOH7trvEMY40y3Byo30HqDPp8m7r7gA5hcg4crRA1hzTEZHjovVULZ1zyd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D1cS02Z/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D1cS02Z/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86979C116D0; Tue, 6 Jan 2026 01:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767664096; bh=gWgwY5gnqLtgEV6SUiR41ffmkBcPFEdij50nSL0+hes=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D1cS02Z/IiZ/s8K97uDEHM5dYKy/+O3nFYUI7ilDtalpIVvtqhiMFcv1hEOKDsdmN GDSS8iBRi5eGjrnmrdiopX7UVwkKDx9p7SvMMO6vbFXPODCXNlN+7cGNcsf7l55q+c GWRZXo0FbB9qVTDeuo5L96s6QVsHcCQTTbw57MsByJDPiiHOPFFersgK4TldbL6Mpm RlV6Gm2uQZhGo3kewmbU7siuXrdz5U+Fo8I0M0LnZL34U70i3zrxBULyH3YReKsjeD 96fnhCjwJiKZiiGleN95KSe9tv/YefQPmx1+9UU/SeDk4Wg8mu6YbFvmyEsdArhIkV KFCigD+v6TQ6A== From: SeongJae Park To: stable@vger.kernel.org Cc: damon@lists.linux.dev, SeongJae Park , Brendan Higgins , David Gow , Kefeng Wang , Andrew Morton Subject: [PATCH 6.12.y] mm/damon/tests/core-kunit: handle alloc failures on damon_test_split_regions_of() Date: Mon, 5 Jan 2026 17:48:13 -0800 Message-ID: <20260106014813.404324-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <2026010533-capricorn-drown-ffcf@gregkh> References: <2026010533-capricorn-drown-ffcf@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_test_split_regions_of() is assuming all dynamic memory allocation in it will succeed. Those are indeed likely in the real use cases since those allocations are too small to fail, but theoretically those could fail. In the case, inappropriate memory access can happen. Fix it by appropriately cleanup pre-allocated memory and skip the execution of the remaining tests in the failure cases. Link: https://lkml.kernel.org/r/20251101182021.74868-9-sj@kernel.org Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") Signed-off-by: SeongJae Park Cc: Brendan Higgins Cc: David Gow Cc: Kefeng Wang Cc: [5.15+] Signed-off-by: Andrew Morton (cherry picked from commit eded254cb69044bd4abde87394ea44909708d7c0) Signed-off-by: SeongJae Park --- mm/damon/tests/core-kunit.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h index cf22e09a3507..54e4086a2df2 100644 --- a/mm/damon/tests/core-kunit.h +++ b/mm/damon/tests/core-kunit.h @@ -227,15 +227,35 @@ static void damon_test_split_regions_of(struct kunit *test) struct damon_target *t; struct damon_region *r; + if (!c) + kunit_skip(test, "ctx alloc fail"); t = damon_new_target(); + if (!t) { + damon_destroy_ctx(c); + kunit_skip(test, "target alloc fail"); + } r = damon_new_region(0, 22); + if (!r) { + damon_destroy_ctx(c); + damon_free_target(t); + kunit_skip(test, "region alloc fail"); + } damon_add_region(r, t); damon_split_regions_of(t, 2); KUNIT_EXPECT_LE(test, damon_nr_regions(t), 2u); damon_free_target(t); t = damon_new_target(); + if (!t) { + damon_destroy_ctx(c); + kunit_skip(test, "second target alloc fail"); + } r = damon_new_region(0, 220); + if (!r) { + damon_destroy_ctx(c); + damon_free_target(t); + kunit_skip(test, "second region alloc fail"); + } damon_add_region(r, t); damon_split_regions_of(t, 4); KUNIT_EXPECT_LE(test, damon_nr_regions(t), 4u); -- 2.47.3