From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D35513FEE; Tue, 6 Jan 2026 02:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767667335; cv=none; b=D23XAj8cJK+h6W1MbSktvg3/QVYuZBztH7HZgKAcnvJAIx5vxn0s50gDjzEuWXlvfHC8ZUt2b68lFcgZ23iubgAKsuODvRxt4InnQIP6XNbbQUV2hCAqHbSl0et5Cgu/GBx2y4AeC6ARIx+3piF7QXKMHO4/GTju/QyqO3C71Ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767667335; c=relaxed/simple; bh=wUK6hjXn4ZjeFex7X+MFt96D02dEpsRF1U83BoPxBgU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R5ncUyguZF+5ipj2l52HYdKHWRl6zEt5xOs58umlsBsMkhaHm61ICDC6ilrB684+0V9P/72/wBuwUZQzhiqNuiDueawnFLnow+wwrO76ibHD6IL9GEyQq9I8lFEoRukVi4IW4aEM+6KsjcKSNVt90C+TE3h65DHycExnW09mMu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=akveEl3i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="akveEl3i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66EC1C19421; Tue, 6 Jan 2026 02:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767667334; bh=wUK6hjXn4ZjeFex7X+MFt96D02dEpsRF1U83BoPxBgU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=akveEl3iefJigZL4ZCBvny37PUgY0kL4YS+n90eKhFaoYdQ4ffo1nFTVktMoMNisM ls+nHrzS8BsQ5mcAYIj+tPEIMLTd+qVx3yr7k3BvS+sqg+7j7lRu664oMM1ubIiolN WvgecVtvIV9OJpIkHOSa4mQAS2C2jgARNXKkzJFzlMvWUxcXd1H0RPp+nFhsZcMDnq 2/DDV8GmypcHH+4dqpjc4wA0wMI+8nIMBTgNIZOXAq67momLsvWThHuHkEk9HDf9uM nEy4vm2J3PKjyXY99jztgflfArhrC1dp4RRB3AKtLxrszlreqkaqPKQQhREl3FJENw LNe3M23uDGEbg== From: SeongJae Park To: stable@vger.kernel.org Cc: damon@lists.linux.dev, SeongJae Park , Brendan Higgins , David Gow , Kefeng Wang , Andrew Morton Subject: [PATCH 6.1.y] mm/damon/tests/core-kunit: handle alloc failures on damon_test_split_regions_of() Date: Mon, 5 Jan 2026 18:42:06 -0800 Message-ID: <20260106024206.807887-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <2026010534-unstaffed-backless-7f21@gregkh> References: <2026010534-unstaffed-backless-7f21@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_test_split_regions_of() is assuming all dynamic memory allocation in it will succeed. Those are indeed likely in the real use cases since those allocations are too small to fail, but theoretically those could fail. In the case, inappropriate memory access can happen. Fix it by appropriately cleanup pre-allocated memory and skip the execution of the remaining tests in the failure cases. Link: https://lkml.kernel.org/r/20251101182021.74868-9-sj@kernel.org Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") Signed-off-by: SeongJae Park Cc: Brendan Higgins Cc: David Gow Cc: Kefeng Wang Cc: [5.15+] Signed-off-by: Andrew Morton (cherry picked from commit eded254cb69044bd4abde87394ea44909708d7c0) Signed-off-by: SeongJae Park --- mm/damon/core-test.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index 3db9b7368756..2fbfbd18d0e3 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -216,15 +216,35 @@ static void damon_test_split_regions_of(struct kunit *test) struct damon_target *t; struct damon_region *r; + if (!c) + kunit_skip(test, "ctx alloc fail"); t = damon_new_target(); + if (!t) { + damon_destroy_ctx(c); + kunit_skip(test, "target alloc fail"); + } r = damon_new_region(0, 22); + if (!r) { + damon_destroy_ctx(c); + damon_free_target(t); + kunit_skip(test, "region alloc fail"); + } damon_add_region(r, t); damon_split_regions_of(t, 2); KUNIT_EXPECT_LE(test, damon_nr_regions(t), 2u); damon_free_target(t); t = damon_new_target(); + if (!t) { + damon_destroy_ctx(c); + kunit_skip(test, "second target alloc fail"); + } r = damon_new_region(0, 220); + if (!r) { + damon_destroy_ctx(c); + damon_free_target(t); + kunit_skip(test, "second region alloc fail"); + } damon_add_region(r, t); damon_split_regions_of(t, 4); KUNIT_EXPECT_LE(test, damon_nr_regions(t), 4u); -- 2.47.3