From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE5535FF49; Tue, 6 Jan 2026 17:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721731; cv=none; b=TNDP9ikAqJ7naAejkMjw10rTYCEXsUtqX39W4wNjIS6Pb2mCVhH1GBgB48osAnSbN1UPEDRk3iVrW1etb1Hc6gHRHGwDGpDtdk8/RsDgIuqwdavJEDJGs8jz4asTMa2VHZm6xsnp2W5K+QNFIBVds8GNLkaYvUHXN+gznEl7mNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767721731; c=relaxed/simple; bh=PaZNuwEYoD9YfjngvFax7qXaIJKezUT1SiYMHrBypRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VgoyICRMRteWx6DAMDQ3Wf/krOwn8sK4PEF+8OLBe3mK3vaByHrf/fcMVSBuOhuL7qJmvaPyDigQclyv4CDluKEWcMbsRCiLVJ/VOthyjJXmALWb0x59mfL5gSkZRhVtQaj/WRd5guxtRPG6uJtKJCwrkyIyDDohYfAXoiHUpHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ekBZb1bW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ekBZb1bW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E50EC116C6; Tue, 6 Jan 2026 17:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767721731; bh=PaZNuwEYoD9YfjngvFax7qXaIJKezUT1SiYMHrBypRA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ekBZb1bWNQTAkfUbnrfpRi/USYx2sR/pMPsL0C0haL9WWJY+OmAG9peUQ43x5fa7Z +zpAoxDsiAgobttdarFCQxeEcmdbbPDOaQJ/q2Zfp0++TNnyNUxLAT6W0UlyQMkAHf GTlqPxA03GSPbNXSUFkwrjtqM/BpoUQeVddubeQM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiumei Mu , Xin Long , Herbert Xu , Sasha Levin Subject: [PATCH 6.18 023/312] crypto: seqiv - Do not use req->iv after crypto_aead_encrypt Date: Tue, 6 Jan 2026 18:01:37 +0100 Message-ID: <20260106170548.694350356@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170547.832845344@linuxfoundation.org> References: <20260106170547.832845344@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Herbert Xu [ Upstream commit 50fdb78b7c0bcc550910ef69c0984e751cac72fa ] As soon as crypto_aead_encrypt is called, the underlying request may be freed by an asynchronous completion. Thus dereferencing req->iv after it returns is invalid. Instead of checking req->iv against info, create a new variable unaligned_info and use it for that purpose instead. Fixes: 0a270321dbf9 ("[CRYPTO] seqiv: Add Sequence Number IV Generator") Reported-by: Xiumei Mu Reported-by: Xin Long Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- crypto/seqiv.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/crypto/seqiv.c b/crypto/seqiv.c index 2bae99e33526..678bb4145d78 100644 --- a/crypto/seqiv.c +++ b/crypto/seqiv.c @@ -50,6 +50,7 @@ static int seqiv_aead_encrypt(struct aead_request *req) struct aead_geniv_ctx *ctx = crypto_aead_ctx(geniv); struct aead_request *subreq = aead_request_ctx(req); crypto_completion_t compl; + bool unaligned_info; void *data; u8 *info; unsigned int ivsize = 8; @@ -68,8 +69,9 @@ static int seqiv_aead_encrypt(struct aead_request *req) memcpy_sglist(req->dst, req->src, req->assoclen + req->cryptlen); - if (unlikely(!IS_ALIGNED((unsigned long)info, - crypto_aead_alignmask(geniv) + 1))) { + unaligned_info = !IS_ALIGNED((unsigned long)info, + crypto_aead_alignmask(geniv) + 1); + if (unlikely(unaligned_info)) { info = kmemdup(req->iv, ivsize, req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP ? GFP_KERNEL : GFP_ATOMIC); @@ -89,7 +91,7 @@ static int seqiv_aead_encrypt(struct aead_request *req) scatterwalk_map_and_copy(info, req->dst, req->assoclen, ivsize, 1); err = crypto_aead_encrypt(subreq); - if (unlikely(info != req->iv)) + if (unlikely(unaligned_info)) seqiv_aead_encrypt_complete2(req, err); return err; } -- 2.51.0