From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D0B36B048; Tue, 6 Jan 2026 17:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722117; cv=none; b=dBIISvmI47BVYrz0wzu97ks6uRva7p1CJrEFHq0nzhrY9NZXjwgZOER1iJZl9w0Lk1XFy3Dmtdk+2uHn4pWOyc4lR3djHXbaantGHQLrjjLvASU9GdZP3nKPVeUW/Qj1/nCu7zEkrbmxggGmE3KxBOLEHpzTahlxOiOIsAoeuAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722117; c=relaxed/simple; bh=9FoGz6uZ6eLxh+GjoBrLEJZYRarl4nFIsKpzIyvWGy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aGAA7ytOYIVCQNfhIJV4U82Aem0VcX8wwg3Dn201lfKSZIdDlfYPn56g79CJtf98tscSpA16/WEDNQVdz0GGZtov8gNUWIAO6NH7SPB9iQepEKqXtwhZ7fiGk3OOG6JN7/KLU7zCk0AdY0e041+uCvHgGk2RmnAETf/SV6HRBnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lc7W/FCi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lc7W/FCi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF339C116C6; Tue, 6 Jan 2026 17:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767722117; bh=9FoGz6uZ6eLxh+GjoBrLEJZYRarl4nFIsKpzIyvWGy4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lc7W/FCi0EPkfns0qNDhrm/ZbrgcvQdOpih6C6iQjo4+1h0uMrZwWUQOi4BtRTemS gh9KQVkEW1pLx7Be3wv+pV2oIPktFQLgar+24SrF3rrfZ3sYQv+X5o8/uZ7qOcc43x 2LiYwc9Z4douL06UBXrXj14WY4Avf1Bs5/PMawJ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ren=C3=A9=20Rebe?= , Helge Deller Subject: [PATCH 6.18 171/312] fbdev: gbefb: fix to use physical address instead of dma address Date: Tue, 6 Jan 2026 18:04:05 +0100 Message-ID: <20260106170554.023059797@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170547.832845344@linuxfoundation.org> References: <20260106170547.832845344@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rene Rebe commit e3f44742bbb10537fe53d83d20dea2a7c167674d upstream. While debuggigng why X would not start on mips64 Sgi/O2 I found the phys adress being off. Turns out the gbefb passed the internal dma_addr as phys. May be broken pre git history. Fix by converting dma_to_phys. Signed-off-by: René Rebe Cc: # v4.0+ Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/gbefb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/gbefb.c +++ b/drivers/video/fbdev/gbefb.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -65,7 +66,7 @@ struct gbefb_par { static unsigned int gbe_mem_size = CONFIG_FB_GBE_MEM * 1024*1024; static void *gbe_mem; static dma_addr_t gbe_dma_addr; -static unsigned long gbe_mem_phys; +static phys_addr_t gbe_mem_phys; static struct { uint16_t *cpu; @@ -1183,7 +1184,7 @@ static int gbefb_probe(struct platform_d goto out_release_mem_region; } - gbe_mem_phys = (unsigned long) gbe_dma_addr; + gbe_mem_phys = dma_to_phys(&p_dev->dev, gbe_dma_addr); } par = info->par;