From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D852357A50; Tue, 6 Jan 2026 17:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722238; cv=none; b=jNaLov6bl/wSoyrBupCSOtMU9isgPtJSB7uloqkR+Vd6tSjDlshBWG8kl2SHufs8UzeUb4cgkw5r3gZ2dsHbMtn6d2ySrgYndW1jrpF8cEZ1wqPZheBguVJdCvsTAYom7o/4VZ/Hti4N4j4dBe4TA7c7TW+J198v/EDPq4H3bTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722238; c=relaxed/simple; bh=jB+M/9c9HeOE5dSS+47yxLy1sr18QXl9JZRxxI5zK8M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fgFQ0isrNqdfvR7Pf14tu28u26Jd+0BhC1lhl98d1on/2lat59jQ39+YN57IRAJPcHTkjI1cWG1hI/mjjCqeidshAH5eDFYF7AcPVyq5IUnAo7EsfU5QaWTY6/szTD1S38wkYqWgTl2h7QgXSTQemb9Dhc0j/kNb3+ZXe6GfTZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FQgr1Kwn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FQgr1Kwn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8417AC116C6; Tue, 6 Jan 2026 17:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767722238; bh=jB+M/9c9HeOE5dSS+47yxLy1sr18QXl9JZRxxI5zK8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FQgr1Kwn9XAxIjmzZ1LycfeRaqduQlR+fgQqDLDkkyLMVRW5SDgBAsG2afNyIyO92 VXXQ5E/79EIbFiPzU2yzwM+/fP69K4MtMTTTNzQisMc8BAJ947QV8MuhQzts4EUT7G o7rcYjMUE6v0rirnXLkRnQ/JttJoWulzJM/UGmKI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, SeongJae Park , Brendan Higgins , David Gow , Kefeng Wang , Andrew Morton Subject: [PATCH 6.18 205/312] mm/damon/tests/core-kunit: handle allocation failures in damon_test_regions() Date: Tue, 6 Jan 2026 18:04:39 +0100 Message-ID: <20260106170555.250111811@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170547.832845344@linuxfoundation.org> References: <20260106170547.832845344@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: SeongJae Park commit e16fdd4f754048d6e23c56bd8d920b71e41e3777 upstream. damon_test_regions() is assuming all dynamic memory allocation in it will succeed. Those are indeed likely in the real use cases since those allocations are too small to fail, but theoretically those could fail. In the case, inappropriate memory access can happen. Fix it by appropriately cleanup pre-allocated memory and skip the execution of the remaining tests in the failure cases. Link: https://lkml.kernel.org/r/20251101182021.74868-3-sj@kernel.org Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") Signed-off-by: SeongJae Park Cc: Brendan Higgins Cc: David Gow Cc: Kefeng Wang Cc: [5.15+] Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- mm/damon/tests/core-kunit.h | 6 ++++++ 1 file changed, 6 insertions(+) --- a/mm/damon/tests/core-kunit.h +++ b/mm/damon/tests/core-kunit.h @@ -20,11 +20,17 @@ static void damon_test_regions(struct ku struct damon_target *t; r = damon_new_region(1, 2); + if (!r) + kunit_skip(test, "region alloc fail"); KUNIT_EXPECT_EQ(test, 1ul, r->ar.start); KUNIT_EXPECT_EQ(test, 2ul, r->ar.end); KUNIT_EXPECT_EQ(test, 0u, r->nr_accesses); t = damon_new_target(); + if (!t) { + damon_free_region(r); + kunit_skip(test, "target alloc fail"); + } KUNIT_EXPECT_EQ(test, 0u, damon_nr_regions(t)); damon_add_region(r, t);