From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F34B319309C; Tue, 6 Jan 2026 18:01:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722486; cv=none; b=c25IibxLgDiMHmhuKLwp5Bw742jHPYNhb55vBqUfjiLZsth1J3dABzd8+q83rEfDj+J3PPXEFmaLCfKLqVKxXBkAXNCUf68wV0PTJLWq9351rbACrpU+PZdreG1ICPPP18Tf9GbNmtq0F6qRKcq1RL9pO40H0vEYMjUDJr/unug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722486; c=relaxed/simple; bh=fnYey1QyOgdydJ/2JdkgsVz9fm0PN6Geq3RPHttz66M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bBmam8VEcEjRP+M7m9y3izMq2bKz49l6XVcXRFxK7MASLGtc3anqvPXzRgVUZZzGT8cNmIR0tHTQLD3YS69xidzNA4nwcvbySLdVsoIqAvWNG3nUZEcFQbMG9FSzKQIfjTq36bG6ldpVbGIaaDcHSs+GfgxFHQPDsVEHp0CHP0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z8e+TOwd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z8e+TOwd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A052C116C6; Tue, 6 Jan 2026 18:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767722485; bh=fnYey1QyOgdydJ/2JdkgsVz9fm0PN6Geq3RPHttz66M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z8e+TOwdbQIH6lUN+mpv9EtyOuFocEmnScpLc4TFIDfI05bUZriv35xnSB2wzvYxk Yb4D1eGrbgiPfTe098I24xKKyB5dz9qs8QVvCgFcGcRu+ss34ChUuJJqPqNVlUHtU8 3CIXnL6RnqQyv/edt/yxx1Rva/G99OxoyibzHrXE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Nancy.Lin" , Johan Hovold , AngeloGioacchino Del Regno , Chun-Kuang Hu Subject: [PATCH 6.18 279/312] drm/mediatek: ovl_adaptor: Fix probe device leaks Date: Tue, 6 Jan 2026 18:05:53 +0100 Message-ID: <20260106170557.945287218@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170547.832845344@linuxfoundation.org> References: <20260106170547.832845344@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit e0f44f74ed6313e50b38eb39a2c7f210ae208db2 upstream. Make sure to drop the references taken to the component devices by of_find_device_by_node() during probe on probe failure (e.g. probe deferral) and on driver unbind. Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195") Cc: stable@vger.kernel.org # 6.4 Cc: Nancy.Lin Signed-off-by: Johan Hovold Reviewed-by: AngeloGioacchino Del Regno Link: https://patchwork.kernel.org/project/dri-devel/patch/20250923152340.18234-6-johan@kernel.org/ Signed-off-by: Chun-Kuang Hu Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c @@ -527,6 +527,13 @@ bool mtk_ovl_adaptor_is_comp_present(str type == OVL_ADAPTOR_TYPE_PADDING; } +static void ovl_adaptor_put_device(void *_dev) +{ + struct device *dev = _dev; + + put_device(dev); +} + static int ovl_adaptor_comp_init(struct device *dev, struct component_match **match) { struct mtk_disp_ovl_adaptor *priv = dev_get_drvdata(dev); @@ -560,6 +567,11 @@ static int ovl_adaptor_comp_init(struct if (!comp_pdev) return -EPROBE_DEFER; + ret = devm_add_action_or_reset(dev, ovl_adaptor_put_device, + &comp_pdev->dev); + if (ret) + return ret; + priv->ovl_adaptor_comp[id] = &comp_pdev->dev; drm_of_component_match_add(dev, match, component_compare_of, node);