From: Greg KH <gregkh@linuxfoundation.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: stable@vger.kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl,
patches@opensource.cirrus.com
Subject: Re: [PATCH RESEND] Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup"
Date: Tue, 6 Jan 2026 15:42:13 +0100 [thread overview]
Message-ID: <2026010637-slightly-regulator-76d9@gregkh> (raw)
In-Reply-To: <20260106111838.1360888-1-ckeepax@opensource.cirrus.com>
On Tue, Jan 06, 2026 at 11:18:38AM +0000, Charles Keepax wrote:
> This reverts commit 25decf0469d4c91d90aa2e28d996aed276bfc622.
For 6.18? There is no such commit in that branch :(
Shouldn't it be e5d527be7e6984882306b49c067f1fec18920735?
>
> This software node change doesn't actually fix any current issues
> with the kernel, it is an improvement to the lookup process rather
> than fixing a live bug. It also causes a couple of regressions with
> shipping laptops, which relied on the label based lookup.
>
> There is a fix for the regressions in mainline, the first 5 patches
> of [1]. However, those patches are fairly substantial changes and
> given the patch causing the regression doesn't actually fix a bug
> it seems better to just revert it in stable.
>
> CC: stable@vger.kernel.org # 6.18
> Link: https://lore.kernel.org/linux-sound/20251120-reset-gpios-swnodes-v7-0-a100493a0f4b@linaro.org/ [1]
> Closes: https://github.com/thesofproject/linux/issues/5599
> Closes: https://github.com/thesofproject/linux/issues/5603
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
> This fix for the software node lookups is also required on 6.18 stable,
> see the discussion for 6.12/6.17 in [2] for why we are doing a revert
> rather than backporting the other fixes. The "full" fixes are merged in
> 6.19 so this should be the last kernel we need to push this revert onto.
Can you resend with the proper commit id in it?
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-06 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 11:18 [PATCH RESEND] Revert "gpio: swnode: don't use the swnode's name as the key for GPIO lookup" Charles Keepax
2026-01-06 14:42 ` Greg KH [this message]
2026-01-06 15:16 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026010637-slightly-regulator-76d9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=brgl@bgdev.pl \
--cc=ckeepax@opensource.cirrus.com \
--cc=linus.walleij@linaro.org \
--cc=patches@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox