From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Dmytro Bagrii" <dimich.dmb@gmail.com>,
"Hans de Goede" <johannes.goede@oss.qualcomm.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sasha Levin" <sashal@kernel.org>,
hansg@kernel.org, pmenzel@molgen.mpg.de, setotau@mainlining.org,
kernel@aiyionpri.me
Subject: [PATCH AUTOSEL 6.18] platform/x86: dell-lis3lv02d: Add Latitude 5400
Date: Wed, 7 Jan 2026 10:53:10 -0500 [thread overview]
Message-ID: <20260107155329.4063936-8-sashal@kernel.org> (raw)
In-Reply-To: <20260107155329.4063936-1-sashal@kernel.org>
From: Dmytro Bagrii <dimich.dmb@gmail.com>
[ Upstream commit a5b9fdd33c59a964a26d12c39b636ef85a25b074 ]
Add accelerometer address 0x29 for Dell Latitude 5400.
The address is verified as below:
$ cat /sys/class/dmi/id/product_name
Latitude 5400
$ grep -H '' /sys/bus/pci/drivers/i801_smbus/0000\:00*/i2c-*/name
/sys/bus/pci/drivers/i801_smbus/0000:00:1f.4/i2c-10/name:SMBus I801 adapter at 0000:00:1f.4
$ i2cdetect 10
WARNING! This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-10.
I will probe address range 0x08-0x77.
Continue? [Y/n] Y
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: 08 -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- UU -- -- -- -- -- --
30: 30 -- -- -- -- 35 UU UU -- -- -- -- -- -- -- --
40: -- -- -- -- 44 -- -- -- -- -- -- -- -- -- -- --
50: UU -- 52 -- -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- -- -- -- -- -- --
$ xargs -n1 -a /proc/cmdline | grep ^dell_lis3lv02d
dell_lis3lv02d.probe_i2c_addr=1
$ dmesg | grep lis3lv02d
...
[ 206.012411] i2c i2c-10: Probing for lis3lv02d on address 0x29
[ 206.013727] i2c i2c-10: Detected lis3lv02d on address 0x29, please report this upstream to platform-driver-x86@vger.kernel.org so that a quirk can be added
[ 206.240841] lis3lv02d_i2c 10-0029: supply Vdd not found, using dummy regulator
[ 206.240868] lis3lv02d_i2c 10-0029: supply Vdd_IO not found, using dummy regulator
[ 206.261258] lis3lv02d: 8 bits 3DC sensor found
[ 206.346722] input: ST LIS3LV02DL Accelerometer as /devices/faux/lis3lv02d/input/input17
$ cat /sys/class/input/input17/name
ST LIS3LV02DL Accelerometer
Signed-off-by: Dmytro Bagrii <dimich.dmb@gmail.com>
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Link: https://patch.msgid.link/20251128161523.6224-1-dimich.dmb@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
## Analysis: platform/x86: dell-lis3lv02d: Add Latitude 5400
### 1. COMMIT MESSAGE ANALYSIS
The commit adds DMI-based accelerometer support for Dell Latitude 5400
laptops. The commit message is exemplary:
- Shows detailed hardware verification using i2cdetect
- Demonstrates the driver itself detected the hardware and prompted the
user to report it upstream
- Has proper Reviewed-by tags from experienced maintainers (Hans de
Goede, Ilpo Järvinen)
### 2. CODE CHANGE ANALYSIS
The change is minimal:
```c
+ DELL_LIS3LV02D_DMI_ENTRY("Latitude 5400", 0x29),
```
This adds a single entry to an existing DMI table, mapping the product
name "Latitude 5400" to I2C address 0x29. The macro
`DELL_LIS3LV02D_DMI_ENTRY` is already defined and used extensively for
other Dell models. The I2C address 0x29 is consistent with other
Latitude models in the list.
### 3. CLASSIFICATION
This falls squarely into the **NEW DEVICE IDs** exception category that
IS appropriate for stable:
- Adds a DMI entry to an existing, working driver
- Analogous to adding PCI IDs or USB IDs
- The driver infrastructure already exists; only the hardware
identification is new
- This is NOT a new feature - it enables existing functionality on
additional hardware
### 4. SCOPE AND RISK ASSESSMENT
- **Lines changed**: 1
- **Files touched**: 1
- **Complexity**: Trivial - adding an entry to a static const table
- **Risk**: Extremely low
- Only affects Dell Latitude 5400 systems
- Uses identical mechanism as all other supported models
- Even if wrong, impact is isolated to one hardware model
- Hardware verified by submitter with actual device
### 5. USER IMPACT
- Users with Dell Latitude 5400 laptops get accelerometer support
- The dmesg output shows the driver detected the hardware and explicitly
asked for an upstream quirk to be added
- Without this entry, the accelerometer is non-functional on this laptop
model
### 6. STABILITY INDICATORS
- **Reviewed-by**: Hans de Goede (prominent x86 platform maintainer)
- **Reviewed-by**: Ilpo Järvinen (Intel kernel maintainer)
- Follows established pattern used by 15+ other entries in the same
table
- Hardware verified on actual Dell Latitude 5400
### 7. DEPENDENCY CHECK
- No dependencies on other commits
- The driver, macro, and infrastructure all exist in stable trees
- Self-contained, atomic change
### CONCLUSION
This is a textbook example of a commit that **should** be backported to
stable:
1. **Obviously correct**: Single-line addition following an established
pattern
2. **Tested**: Verified on actual hardware
3. **Fixes a real issue**: Enables accelerometer on hardware that has
one
4. **Small and contained**: One line, minimal risk
5. **Exception category**: This is exactly the type of device ID/DMI
entry addition that stable rules explicitly allow
The risk is near-zero (only affects one specific laptop model), and the
benefit is real (enables hardware functionality for Latitude 5400
users). This type of trivial hardware enablement is routinely and
appropriately backported to stable trees.
**YES**
drivers/platform/x86/dell/dell-lis3lv02d.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell/dell-lis3lv02d.c b/drivers/platform/x86/dell/dell-lis3lv02d.c
index 77905a9ddde9..fe52bcd896f7 100644
--- a/drivers/platform/x86/dell/dell-lis3lv02d.c
+++ b/drivers/platform/x86/dell/dell-lis3lv02d.c
@@ -44,6 +44,7 @@ static const struct dmi_system_id lis3lv02d_devices[] __initconst = {
/*
* Additional individual entries were added after verification.
*/
+ DELL_LIS3LV02D_DMI_ENTRY("Latitude 5400", 0x29),
DELL_LIS3LV02D_DMI_ENTRY("Latitude 5480", 0x29),
DELL_LIS3LV02D_DMI_ENTRY("Latitude 5500", 0x29),
DELL_LIS3LV02D_DMI_ENTRY("Latitude E6330", 0x29),
--
2.51.0
next prev parent reply other threads:[~2026-01-07 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 15:53 [PATCH AUTOSEL 6.18-5.15] smb/server: call ksmbd_session_rpc_close() on error path in create_smb2_pipe() Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18] io_uring: use GFP_NOWAIT for overflow CQEs on legacy rings Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-6.6] smb/server: fix refcount leak in smb2_open() Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18] wifi: mac80211: don't WARN for connections on invalid channels Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-5.10] net: usb: sr9700: support devices with virtual driver CD Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-5.10] wifi: mac80211: ocb: skip rx_no_sta when interface is not joined Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-5.10] block,bfq: fix aux stat accumulation destination Sasha Levin
2026-01-07 15:53 ` Sasha Levin [this message]
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-5.10] wifi: wlcore: ensure skb headroom before skb_push Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-6.6] smb/server: fix refcount leak in parse_durable_handle_context() Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18] wifi: iwlwifi: Implement settime64 as stub for MVM/MLD PTP Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-6.1] LoongArch: Set correct protection_map[] for VM_NONE/VM_SHARED Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-6.1] LoongArch: Enable exception fixup for specific ADE subcode Sasha Levin
2026-01-07 15:53 ` [PATCH AUTOSEL 6.18-6.12] md: suspend array while updating raid_disks via sysfs Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107155329.4063936-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dimich.dmb@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johannes.goede@oss.qualcomm.com \
--cc=kernel@aiyionpri.me \
--cc=patches@lists.linux.dev \
--cc=pmenzel@molgen.mpg.de \
--cc=setotau@mainlining.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox