public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: "Sasha Levin" <sashal@kernel.org>,
	"Thorsten Glaser" <tg@mirbsd.de>,
	"Helge Deller" <deller@kernel.org>,
	"Junjie Cao" <junjie.cao@intel.com>,
	"Gianluca Renzi" <gianlucarenzi@eurek.it>,
	Camaleón <noelamac@gmail.com>,
	"William Burrow" <wbkernel@gmail.com>,
	1123750@bugs.debian.org,
	"Salvatore Bonaccorso" <carnil@debian.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [5.10] regression: virtual consoles 2-12 unusable
Date: Thu, 8 Jan 2026 14:23:12 +0100	[thread overview]
Message-ID: <2026010803-gem-puzzle-640d@gregkh> (raw)
In-Reply-To: <c5a27a57597c78553bf121d09a1b45ed86dc02a8.camel@decadent.org.uk>

On Fri, Jan 02, 2026 at 05:26:22PM +0100, Ben Hutchings wrote:
> Hello stable maintainers,
> 
> Several Debian users reported a regression after updating to kernel
> version 5.10.247.
> 
> Commit f0982400648a ("fbdev: Add bounds checking in bit_putcs to fix
> vmalloc-out-of-bounds"), a backport of upstream commit 3637d34b35b2,
> depends on vc_data::vc_font.charcount being initialised correctly.
> 
> However, before commit a1ac250a82a5 ("fbcon: Avoid using FNTCHARCNT()
> and hard-coded built-in font charcount") in 5.11, this member was set
> to 256 for VTs initially created with a built-in font and 0 for VTs
> initially created with a user font.
> 
> Since Debian normally sets a user font before creating VTs 2 and up,
> those additional VTs became unusable.  VT 1 also doesn't work correctly
> if the user font has > 256 characters, and the bounds check is
> ineffective if it has < 256 characters.
> 
> This can be fixed by backporting the following commits from 5.11:
> 
> 7a089ec7d77f console: Delete unused con_font_copy() callback implementations
> 259a252c1f4e console: Delete dummy con_font_set() and con_font_default() callback implementations
> 4ee573086bd8 Fonts: Add charcount field to font_desc
> 4497364e5f61 parisc/sticore: Avoid hard-coding built-in font charcount
> a1ac250a82a5 fbcon: Avoid using FNTCHARCNT() and hard-coded built-in font charcount
> 
> These all apply without fuzz and builds cleanly for x86_64 and parisc64.
> 
> I tested on x86_64 that:
> 
> - VT 2 works again
> - bit_putcs_aligned() is setting charcnt = 256
> - After loading a font with 512 characters, bit_putcs_aligned() sets
>   charcnt = 512 and is able to display characters at positions >= 256

All now queued up, thanks!

greg k-h

  reply	other threads:[~2026-01-08 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <aUeSb_SicXsVpmHn@eldamar.lan>
     [not found] ` <Pine.BSM.4.64L.2512211617050.3154@herc.mirbsd.org>
     [not found]   ` <aU68arLtS1_wZiMj@eldamar.lan>
     [not found]     ` <176626831842.2137.9290349746475307418.reportbug@x61p.mirbsd.org>
     [not found]       ` <CAN2UaigCW-BZTifuo-ADCw=uDq85A_KwOHcceyaXDnVo8OQZiQ@mail.gmail.com>
2026-01-02 16:26         ` [5.10] regression: virtual consoles 2-12 unusable Ben Hutchings
2026-01-08 13:23           ` Greg Kroah-Hartman [this message]
2026-01-15  8:41             ` Barry K. Nathan
2026-01-28 14:21               ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026010803-gem-puzzle-640d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=1123750@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=carnil@debian.org \
    --cc=deller@kernel.org \
    --cc=gianlucarenzi@eurek.it \
    --cc=junjie.cao@intel.com \
    --cc=noelamac@gmail.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tg@mirbsd.de \
    --cc=wbkernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox