From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E0C352952; Fri, 9 Jan 2026 12:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962121; cv=none; b=Cqa+JLqHyoPYWg1mJJ2vioBYfEsjpOWBf5HvPi8mLsYLoOWbOQqVyaqvWrGhD3tB1G6zyJXtle/3hKiKD2r1iRSNmMsAomXZZo5X9bU01SCa5detPhSHjmcZLrCEDGSp3BryXniSbk/Cfhl2TifTUbP0dxAdoEroGKwErXPQq4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962121; c=relaxed/simple; bh=45Yfmpz2FigljUsNYGDIM4dtwyB+bCk01hme1RsLviw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ya4/accdmVPwpiDcEeRF3QM5hyMBefJhEILtC4IxGfP4YbiuB898+pZMIa4xhvlBjbslARN/s6zVxB6/2+YJHdcJC428vSI3Owqcx0FJXfBd+pNHooyJsclBqJpJfEGFAUH2PpOORDbWv2/moFtHSQLJxhrIn9Zq3elJQTZcO+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K/AUyDKA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K/AUyDKA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0B14C4CEF1; Fri, 9 Jan 2026 12:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767962121; bh=45Yfmpz2FigljUsNYGDIM4dtwyB+bCk01hme1RsLviw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K/AUyDKAXNkl1I1eMBEqSRhEKWKDJ/iVq7cXapkjprjPe6052OydYQYX71PpTpj4w MdQkDjUUHYua5vzrc4m3fid65Li25yb1GMseOPYg9Mn7vrpHHvvfRHgy8b5u+yRUeb BXwyQQ+XwpSKQYDkdlzqgZc9sKwSoOiUqB4G7VP4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jonas Gorski , Andrew Lunn , Alexey Simakov , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 254/634] broadcom: b44: prevent uninitialized value usage Date: Fri, 9 Jan 2026 12:38:52 +0100 Message-ID: <20260109112127.097555187@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112117.407257400@linuxfoundation.org> References: <20260109112117.407257400@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexey Simakov [ Upstream commit 50b3db3e11864cb4e18ff099cfb38e11e7f87a68 ] On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy() leaves bmcr value uninitialized and it is used later in the code. Add check of this flag at the beginning of the b44_nway_reset() and exit early of the function with restarting autonegotiation if an external PHY is used. Fixes: 753f492093da ("[B44]: port to native ssb support") Reviewed-by: Jonas Gorski Reviewed-by: Andrew Lunn Signed-off-by: Alexey Simakov Reviewed-by: Michael Chan Link: https://patch.msgid.link/20251205155815.4348-1-bigalex934@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/b44.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c index 5b6209f5a8017..b3e3e869c4379 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c @@ -1811,6 +1811,9 @@ static int b44_nway_reset(struct net_device *dev) u32 bmcr; int r; + if (bp->flags & B44_FLAG_EXTERNAL_PHY) + return phy_ethtool_nway_reset(dev); + spin_lock_irq(&bp->lock); b44_readphy(bp, MII_BMCR, &bmcr); b44_readphy(bp, MII_BMCR, &bmcr); -- 2.51.0