From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3F3359703; Fri, 9 Jan 2026 12:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962572; cv=none; b=Fd7zvcyi1xRvsYRlujSCY2Nvzg0x8RjxCqEqKU8zkcFW6IPrgKZOHXG4GBmIclm/1qO7mPY0kwhRyVN7VfaRCoLk2UvOyyElvrxSsS0DvuUdOby0bAe8+mt8J2lFBJ+dMoKukoKwlT4EwQE7nbaqDNIEA7N+naWFzLF5BrSxFeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962572; c=relaxed/simple; bh=a0AnuVmTsUuLZGIrrktIr6cCREZKPSUxp0I4H5rza3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pA8NwEo9CiFq3tZUUD+cu/O9fPF8AZLJgcofklXX+WoF4iTg/uZPeHx5O52V1I3gFR+Nwoe1pqpQQGUAGy6TH60c/c51xaywT3zK2a36k0KSwJbaa8lqrtRvG3LijAdZG5oAhFTDoL1q4Lw5JsgH3Pb9+d2dKovUFLKLAI4SUf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZQhxq9U0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZQhxq9U0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 192A3C4CEF1; Fri, 9 Jan 2026 12:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767962572; bh=a0AnuVmTsUuLZGIrrktIr6cCREZKPSUxp0I4H5rza3U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZQhxq9U0ljjs6xSTaXrA67boZiisOxrhb/AfUUqBsWkbJUTOQtOeeG02QZ0xZzHD1 eUfPyNfXZLHl6PDr7n51Bx4jQoDZIjUd1nFZ6X4+y1e2m6Ah6ERN7InKQx/m9GJw7K OFrRTxd5fEQ8fZ1zXmo0IMnV5sXssUyAulBO+WQI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gui-Dong Han , Guenter Roeck Subject: [PATCH 6.1 385/634] hwmon: (max16065) Use local variable to avoid TOCTOU Date: Fri, 9 Jan 2026 12:41:03 +0100 Message-ID: <20260109112132.018986575@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112117.407257400@linuxfoundation.org> References: <20260109112117.407257400@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gui-Dong Han commit b8d5acdcf525f44e521ca4ef51dce4dac403dab4 upstream. In max16065_current_show, data->curr_sense is read twice: once for the error check and again for the calculation. Since i2c_smbus_read_byte_data returns negative error codes on failure, if the data changes to an error code between the check and the use, ADC_TO_CURR results in an incorrect calculation. Read data->curr_sense into a local variable to ensure consistency. Note that data->curr_gain is constant and safe to access directly. This aligns max16065_current_show with max16065_input_show, which already uses a local variable for the same reason. Link: https://lore.kernel.org/all/CALbr=LYJ_ehtp53HXEVkSpYoub+XYSTU8Rg=o1xxMJ8=5z8B-g@mail.gmail.com/ Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han Link: https://lore.kernel.org/r/20251128124709.3876-1-hanguidong02@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/max16065.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/hwmon/max16065.c +++ b/drivers/hwmon/max16065.c @@ -216,12 +216,13 @@ static ssize_t max16065_current_show(str struct device_attribute *da, char *buf) { struct max16065_data *data = max16065_update_device(dev); + int curr_sense = data->curr_sense; - if (unlikely(data->curr_sense < 0)) - return data->curr_sense; + if (unlikely(curr_sense < 0)) + return curr_sense; return sysfs_emit(buf, "%d\n", - ADC_TO_CURR(data->curr_sense, data->curr_gain)); + ADC_TO_CURR(curr_sense, data->curr_gain)); } static ssize_t max16065_limit_store(struct device *dev,