From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD10C35971B; Fri, 9 Jan 2026 12:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962662; cv=none; b=tqRxpYxMd5oJNkopby2ngNDSjwUk980MUbXSxH22XV3G9W0De6WShzyBsuMcThpzTZiUzHSjvmFAGn8dpglyJ9h+hZAVRs7gTduaXuTjJJhh4El1tmQtINAQRNtdtn3NX7OGlzP0uxXzQhucWTMGwR/IhRrddcLi8XcvRVKcVkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962662; c=relaxed/simple; bh=oJSAUgrJOMI+HNYSYlX9rK+pc4vkmOSMgvVgqoJIB/c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TjlFx9WS+C1EA1WoYBfdQfTa+rKW5xKdyDaaELwsHDe6YRWmRKDnK7o276mdTcb41s1sZSqjMJRPimbwtQUTfCSq9t6Hd3+Ey+73luczC6WQ30jItOc1qDpgLdFN3Thj78VQ01JfyHgLgdE6A8MsgVRRBOBiK8NQY5KfWyFyJSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=gaSV3wCI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="gaSV3wCI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5810EC4CEF1; Fri, 9 Jan 2026 12:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767962662; bh=oJSAUgrJOMI+HNYSYlX9rK+pc4vkmOSMgvVgqoJIB/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gaSV3wCIW2XhgsVtYM+oGvfpcn5ZV6LH5N3yK4u67u4sumEJYbeeFYIuHTmQstPq2 YQ+DJar5gmCD5hjTF//9Z+FTLNwATrRRVrVo+AXcrhzToQi8ygAx0weyO5622OjF9H E2Iqr6MHxyEEDgdv4XibI1PTaOpgwWWXX6FpCEwk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, olivier moysan , Wen Yang , Johan Hovold , olivier moysan , Mark Brown Subject: [PATCH 6.1 444/634] ASoC: stm32: sai: fix device leak on probe Date: Fri, 9 Jan 2026 12:42:02 +0100 Message-ID: <20260109112134.245036325@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112117.407257400@linuxfoundation.org> References: <20260109112117.407257400@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit e26ff429eaf10c4ef1bc3dabd9bf27eb54b7e1f4 upstream. Make sure to drop the reference taken when looking up the sync provider device and its driver data during DAI probe on probe failures and on unbind. Note that holding a reference to a device does not prevent its driver data from going away so there is no point in keeping the reference. Fixes: 7dd0d835582f ("ASoC: stm32: sai: simplify sync modes management") Fixes: 1c3816a19487 ("ASoC: stm32: sai: add missing put_device()") Cc: stable@vger.kernel.org # 4.16: 1c3816a19487 Cc: olivier moysan Cc: Wen Yang Signed-off-by: Johan Hovold Reviewed-by: olivier moysan Link: https://patch.msgid.link/20251124104908.15754-2-johan@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/stm/stm32_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/stm/stm32_sai.c +++ b/sound/soc/stm/stm32_sai.c @@ -127,6 +127,7 @@ static int stm32_sai_set_sync(struct stm } sai_provider = platform_get_drvdata(pdev); + put_device(&pdev->dev); if (!sai_provider) { dev_err(&sai_client->pdev->dev, "SAI sync provider data not found\n"); @@ -143,7 +144,6 @@ static int stm32_sai_set_sync(struct stm ret = stm32_sai_sync_conf_provider(sai_provider, synco); error: - put_device(&pdev->dev); of_node_put(np_provider); return ret; }