From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541A635C1AF; Fri, 9 Jan 2026 12:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962710; cv=none; b=eSb/Oap76zSQsXtS64pZUK6O8KqwUgIMsq6vkd7U7qYgZ/nPXa+UsRXugpcn4dK+NScEEMjYoJlKJGxyFBZl8srZ5GgY6YvikqGh7UbJAot1FZtxJVzTRrGGuBHXf6YFCV+aR0aphOdKBbhKq6gKCjpPzw/n/+MBhBFpghw8wDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767962710; c=relaxed/simple; bh=u+l0O9FXMuxN9RXc8D0JV3NriOo2PPnqD4OBwcmDGVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W6azkrN2hcPVnTc2kKdT9pf6HvzRAfSZYMbEJ4tS5UMO8+Qs4TG1UtlGqhVxiOnvTnsNOyOw5HBP8SYm+zrLPKfhNlkBCXhPixBL8ZQSfOe/dSfGKfL8RImztJvga3KIVTd/u2xrXC6wWVh8pag8p5wr0V1Lh28PnLnrw706NYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CH6hqDs1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CH6hqDs1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6F65C4CEF1; Fri, 9 Jan 2026 12:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767962710; bh=u+l0O9FXMuxN9RXc8D0JV3NriOo2PPnqD4OBwcmDGVw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CH6hqDs14QY+5YatNseJ2TNbe6yCtXohMopQOZXBXpUNzTRV8zi9GJvqtYxZB6RMT reJUxz2q9CPvpI6JNLvPGGWk2JVhthwP/8gpqCKrTF+w83CZKDa57zYz+02D/SExSU pA5WvLdY4iaWv7lJueV+Bt8NRgacL7O0w5LXkPiU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Honghui Zhang , Robin Murphy , Yong Wu , Johan Hovold , AngeloGioacchino Del Regno , Joerg Roedel Subject: [PATCH 6.1 453/634] iommu/mediatek-v1: fix device leak on probe_device() Date: Fri, 9 Jan 2026 12:42:11 +0100 Message-ID: <20260109112134.589430716@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112117.407257400@linuxfoundation.org> References: <20260109112117.407257400@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit c77ad28bfee0df9cbc719eb5adc9864462cfb65b upstream. Make sure to drop the reference taken to the iommu platform device when looking up its driver data during probe_device(). Fixes: b17336c55d89 ("iommu/mediatek: add support for mtk iommu generation one HW") Cc: stable@vger.kernel.org # 4.8 Cc: Honghui Zhang Acked-by: Robin Murphy Reviewed-by: Yong Wu Signed-off-by: Johan Hovold Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Joerg Roedel Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/mtk_iommu_v1.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/iommu/mtk_iommu_v1.c +++ b/drivers/iommu/mtk_iommu_v1.c @@ -422,6 +422,8 @@ static int mtk_iommu_v1_create_mapping(s return -EINVAL; dev_iommu_priv_set(dev, platform_get_drvdata(m4updev)); + + put_device(&m4updev->dev); } ret = iommu_fwspec_add_ids(dev, args->args, 1);