From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1EB35C197; Fri, 9 Jan 2026 12:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767963041; cv=none; b=giNUjBsOrs1Jv3Jqm4IcCfoGUoR6fOzDtFGp4x6+okY9hZHz1+nF4cERxodMuw6EH2aHWBCPvyj5Lzuu5fq+U46DC4rOPi5kwGjrG5K/eUB5mme+JjFixCWq/Ts2BRJQvEP3ZNvL5Fx8VJYXmRTzOhtkjulFewDgweTJoOrdQpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767963041; c=relaxed/simple; bh=vvz3oeePXhvDLMv+VD9GzhFZESRtGWY8RBp6vD26XIM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rBIwt0KTtZafKrQC5ICzkMadYSWPoAtXBdoO5izxWblh6MUTy4qhg8qCp1uYZklpUNczWLahITTQlT7Bj7PRQBmJNaU7Wsp5OO7G2qiHuDKtWhqWwHd3V2JVj319ukPe4KpuUz+c36E9hjbHNrYcrAiXNfsZOKTIMx9i+C6UY/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uf9MEWNq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uf9MEWNq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A36E9C4CEF1; Fri, 9 Jan 2026 12:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767963041; bh=vvz3oeePXhvDLMv+VD9GzhFZESRtGWY8RBp6vD26XIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uf9MEWNqkI6EoBJ2Z2lvoilF9aHRghcg0L8xFUWma1k7fmgsC7hbtORJEPNZot56y RiUBersYm6XlZq7R2QTmD88pIiMHbiuwbxj83d8Q32/3S0KN/korwfM4/RQjCB375g Cuv63FKu1pNa76aWGNO/KuoN3xWAge7cBF+JhxXA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeff Layton , Chuck Lever , Sasha Levin Subject: [PATCH 6.1 559/634] NFSD: Clear SECLABEL in the suppattr_exclcreat bitmap Date: Fri, 9 Jan 2026 12:43:57 +0100 Message-ID: <20260109112138.632099044@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112117.407257400@linuxfoundation.org> References: <20260109112117.407257400@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chuck Lever [ Upstream commit 27d17641cacfedd816789b75d342430f6b912bd2 ] >>>From RFC 8881: 5.8.1.14. Attribute 75: suppattr_exclcreat > The bit vector that would set all REQUIRED and RECOMMENDED > attributes that are supported by the EXCLUSIVE4_1 method of file > creation via the OPEN operation. The scope of this attribute > applies to all objects with a matching fsid. There's nothing in RFC 8881 that states that suppattr_exclcreat is or is not allowed to contain bits for attributes that are clear in the reported supported_attrs bitmask. But it doesn't make sense for an NFS server to indicate that it /doesn't/ implement an attribute, but then also indicate that clients /are/ allowed to set that attribute using OPEN(create) with EXCLUSIVE4_1. Ensure that the SECURITY_LABEL and ACL bits are not set in the suppattr_exclcreat bitmask when they are also not set in the supported_attrs bitmask. Fixes: 8c18f2052e75 ("nfsd41: SUPPATTR_EXCLCREAT attribute") Cc: stable@vger.kernel.org Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever [ Adjust context ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfs4xdr.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -3408,6 +3408,11 @@ out_acl: u32 supp[3]; memcpy(supp, nfsd_suppattrs[minorversion], sizeof(supp)); + if (!IS_POSIXACL(d_inode(dentry))) + supp[0] &= ~FATTR4_WORD0_ACL; + if (!contextsupport) + supp[2] &= ~FATTR4_WORD2_SECURITY_LABEL; + supp[0] &= NFSD_SUPPATTR_EXCLCREAT_WORD0; supp[1] &= NFSD_SUPPATTR_EXCLCREAT_WORD1; supp[2] &= NFSD_SUPPATTR_EXCLCREAT_WORD2;