From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A47C1482E8; Fri, 9 Jan 2026 12:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767963065; cv=none; b=sRIpNxgtbnqKwS+Pys/Vc8W6tqy5ZOBgtYtKyiOJLB23DNMiUXdbAJNBzszyRhgkT/JLpXMlMi40uUXs5HwU1iD9INRvYta/cI2ZQb7lkTkqwptT0PlIODJBvbvHkVa/pK+LG7I1XcB0STxBuyeNN5nrtl8bLl5VAgK92hp9CHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767963065; c=relaxed/simple; bh=4xJ8rDCDe1ShWiWJIYJQrQMDGcxwx8Lef5spPpMerfg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=td8hrDIxB/bqQBYxKMCYHWe0WVNvUdx1kFkUZBzAlwj3T+KqsZacEmg4J6aDF0K8d6tLywW3bv/8WPvjRWd8DAl8XAcNvQblZIZzLD+umE0Gs9ZfA0uuacrI18/qxSEU2n+RiKL05Rm7o3ZzkY6J11YIoJGdtoBGJr00g8a+B2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GbH0OEV0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GbH0OEV0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FFBAC4CEF1; Fri, 9 Jan 2026 12:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767963064; bh=4xJ8rDCDe1ShWiWJIYJQrQMDGcxwx8Lef5spPpMerfg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GbH0OEV0SpmNgUVyxGHNgKIKKPn44JyJDw6usjBj+mbtN6d+Vz4pA/8ufy/cMp/rN cRgsWQLDggilNGTBit7Z6Xi0bz+D7B1zLLT8WKhd+Nz8hU2BpCz7GVfCGIskfFyH/5 h7fdafZ4WU+Nao4yK/rgX9ml2DDbyhn4DY5fFE4c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haoxiang Li , AngeloGioacchino Del Regno , Tzung-Bi Shih , Nicolas Dufresne , Hans Verkuil , Sasha Levin Subject: [PATCH 6.1 584/634] media: mediatek: vcodec: Fix a reference leak in mtk_vcodec_fw_vpu_init() Date: Fri, 9 Jan 2026 12:44:22 +0100 Message-ID: <20260109112139.590006922@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112117.407257400@linuxfoundation.org> References: <20260109112117.407257400@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li [ Upstream commit cdd0f118ef87db8a664fb5ea366fd1766d2df1cd ] vpu_get_plat_device() increases the reference count of the returned platform device. However, when devm_kzalloc() fails, the reference is not released, causing a reference leak. Fix this by calling put_device() on fw_pdev->dev before returning on the error path. Fixes: e25a89f743b1 ("media: mtk-vcodec: potential dereference of null pointer") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Tzung-Bi Shih Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil [ adapted file path from common/ subdirectory and adjusted devm_kzalloc target from plat_dev->dev to dev->plat_dev->dev ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/mediatek/vcodec/mtk_vcodec_fw_vpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_fw_vpu.c +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_fw_vpu.c @@ -94,8 +94,10 @@ struct mtk_vcodec_fw *mtk_vcodec_fw_vpu_ vpu_wdt_reg_handler(fw_pdev, mtk_vcodec_vpu_reset_handler, dev, rst_id); fw = devm_kzalloc(&dev->plat_dev->dev, sizeof(*fw), GFP_KERNEL); - if (!fw) + if (!fw) { + put_device(&fw_pdev->dev); return ERR_PTR(-ENOMEM); + } fw->type = VPU; fw->ops = &mtk_vcodec_vpu_msg; fw->pdev = fw_pdev;