From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F25CE32BF21; Fri, 9 Jan 2026 11:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767959908; cv=none; b=fvGJiyUifG3+cITDwi3nb3POA3DDY/s005rZ2Gdlq046EP1vwRjJW7edP4tOo7GYPQiFZs3NbQ9wNUOdc/06X08Fug6qSgfMFWRH7DVoDbWt8zCilVhUcQzwlzlB4fZcjyq08478ZB5c0QUiG5Wr4PTVEG7lblnHkwfyz8RmPzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767959908; c=relaxed/simple; bh=BKNe0ib/rb4oqfCNskh6ZnnkpMy0KrI3A3iJwk3DT2I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LTBOiVXP2yM9HTlE6OlDxETUcT/UJx6Ly7VqZ3TwPCTKK7YchWXAfMZcVVCmlE8hI9o/aRqJ2dLYlLQ3AwcNiBnIGNoTOY/gF6B4bBjsC/UCRgWQOMwL7BBCbCgbAkYhIkWKR5n+czwPdLeAveRwG/fAM8SRdfnu1fjuQqewnfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H2/YnsCM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H2/YnsCM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80553C4CEF1; Fri, 9 Jan 2026 11:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767959907; bh=BKNe0ib/rb4oqfCNskh6ZnnkpMy0KrI3A3iJwk3DT2I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H2/YnsCMeIAdLEJAlcnIXVY6GylLBckaZcg7IMqov7oKCcIVR3YpO2gTo3CR8G1yr QUI4cIsC8QwMfZjZpKhezjNBiCjUxfDFaLngKkFYEDMiAUezxmjolgrcJer/7+D6Bb Wj11XNQ5mEB5pciKKpAcCeZJ1w+S6XOEKqOrYrVs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alexander Dahl , "Russell King (Oracle)" , =?UTF-8?q?Nuno=20S=C3=A1?= , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 185/737] net: phy: adin1100: Fix software power-down ready condition Date: Fri, 9 Jan 2026 12:35:24 +0100 Message-ID: <20260109112140.954686404@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112133.973195406@linuxfoundation.org> References: <20260109112133.973195406@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alexander Dahl [ Upstream commit bccaf1fe08f2c9f96f6bc38391d41e67f6bf38e3 ] Value CRSM_SFT_PD written to Software Power-Down Control Register (CRSM_SFT_PD_CNTRL) is 0x01 and therefor different to value CRSM_SFT_PD_RDY (0x02) read from System Status Register (CRSM_STAT) for confirmation powerdown has been reached. The condition could have only worked when disabling powerdown (both 0x00), but never when enabling it (0x01 != 0x02). Result is a timeout, like so: $ ifdown eth0 macb f802c000.ethernet eth0: Link is Down ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110 ADIN1100 f802c000.ethernet-ffffffff:01: adin_set_powerdown_mode failed: -110 Fixes: 7eaf9132996a ("net: phy: adin1100: Add initial support for ADIN1100 industrial PHY") Signed-off-by: Alexander Dahl Reviewed-by: Russell King (Oracle) Acked-by: Nuno Sá Link: https://patch.msgid.link/20251119124737.280939-2-ada@thorsis.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/phy/adin1100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/adin1100.c b/drivers/net/phy/adin1100.c index 7619d6185801c..2f47b7020e12b 100644 --- a/drivers/net/phy/adin1100.c +++ b/drivers/net/phy/adin1100.c @@ -148,7 +148,7 @@ static int adin_set_powerdown_mode(struct phy_device *phydev, bool en) return ret; return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1, ADIN_CRSM_STAT, ret, - (ret & ADIN_CRSM_SFT_PD_RDY) == val, + !!(ret & ADIN_CRSM_SFT_PD_RDY) == en, 1000, 30000, true); } -- 2.51.0