From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD8C723ED5B; Fri, 9 Jan 2026 12:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767960748; cv=none; b=FAZAIbvWzP3kGSsQLkS4Z5Cujtwf/mneh38LJLeKbauDCeswULG+7Ek8wbjds8un+NOj7FrjseJ6E3yKj+LekTLHC/8rJxJ+1Th9csTLRukaNG+ZSGXGF7w769sMCeI6iBivkITXMbX/mLOr3B0iq9ap/8xlNJtOgw70I5bxtxQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767960748; c=relaxed/simple; bh=zfCKV9TPRfBrgNpqLHojvmC5p/824mVaD1bXaHdN8Bs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Wnl3WGwq9+VqOdXFFwG1z3XAcXY7jUSuaBINKpUCWkYUj9A8bOqDNPaWZPzsH4ZD/Wi+rslTDxSsmRjwyhif/ZgWc8h7x5A80NMVHBdXmfyoDLKQvkTRdBdgf+11Uzak5tYD12SExP/nh/EQ+XYWfcdauIELvvH24GZfRfzhbZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=D02nH8ZK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="D02nH8ZK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58F05C4CEF1; Fri, 9 Jan 2026 12:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767960748; bh=zfCKV9TPRfBrgNpqLHojvmC5p/824mVaD1bXaHdN8Bs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D02nH8ZK2+Fu/lvDLHc3SSj77SGmnfajNUAzaXUGCUCzie32s4Iou7md8A3arKIWS bFTD5WRkKK3e+xHTxqEAa0QFTQywSqlrIypJl4BlcTAsprZvOeI13zfIEIIBRQYHTC DzfuFriYudEzfo4V6zJkRkWzoYDGXMtBGszQ01h0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuhao Jiang , Junrui Luo , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 6.6 512/737] platform/x86: ibm_rtl: fix EBDA signature search pointer arithmetic Date: Fri, 9 Jan 2026 12:40:51 +0100 Message-ID: <20260109112153.258668017@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112133.973195406@linuxfoundation.org> References: <20260109112133.973195406@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Junrui Luo [ Upstream commit 15dd100349b8526cbdf2de0ce3e72e700eb6c208 ] The ibm_rtl_init() function searches for the signature but has a pointer arithmetic error. The loop counter suggests searching at 4-byte intervals but the implementation only advances by 1 byte per iteration. Fix by properly advancing the pointer by sizeof(unsigned int) bytes each iteration. Reported-by: Yuhao Jiang Reported-by: Junrui Luo Fixes: 35f0ce032b0f ("IBM Real-Time "SMI Free" mode driver -v7") Signed-off-by: Junrui Luo Link: https://patch.msgid.link/SYBPR01MB78812D887A92DE3802D0D06EAFA9A@SYBPR01MB7881.ausprd01.prod.outlook.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/ibm_rtl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/ibm_rtl.c b/drivers/platform/x86/ibm_rtl.c index 2ab7d9ac542d..5fb25a602533 100644 --- a/drivers/platform/x86/ibm_rtl.c +++ b/drivers/platform/x86/ibm_rtl.c @@ -272,7 +272,7 @@ static int __init ibm_rtl_init(void) { /* search for the _RTL_ signature at the start of the table */ for (i = 0 ; i < ebda_size/sizeof(unsigned int); i++) { struct ibm_rtl_table __iomem * tmp; - tmp = (struct ibm_rtl_table __iomem *) (ebda_map+i); + tmp = (struct ibm_rtl_table __iomem *) (ebda_map + i*sizeof(unsigned int)); if ((readq(&tmp->signature) & RTL_MASK) == RTL_SIGNATURE) { phys_addr_t addr; unsigned int plen; -- 2.51.0