From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 038EF1946C8; Fri, 9 Jan 2026 12:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767960777; cv=none; b=p8kugizaLAn1iFl/as7Y7pAHM8PxUxCrxNXBlNg7zKMxayINkdcd8pcS1I0inq/Qha8QYNuLoJ3VCTeKrzPIlh5r+5+HnaLM7FxwndYhVad3pfdOV9NbfwU5fidNhAvOV5+NqQ672RkGx2TS21R7KBifr9TXVMutQcX0BcDj7pQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767960777; c=relaxed/simple; bh=L85XqhRnJ7U1d2xZzDxSAT0WPGAOdEmDlyJl+kbvYfw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rHmHz1uomziiJFIicsJko+D73BcSv1M5oNO+DDZBKG0UYdIUYoAIARHxq4cCJCtz6CBVtJCvyIT4yhMLspvrC+gw61lSQaMKgFydBotYGPnfi46ay+ipuQj172bgByp/MsIxK3W59yxrS+/w1zKxXdGAQewL/JVplNqTWijfI5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mDFJx/dI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mDFJx/dI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88C29C4CEF1; Fri, 9 Jan 2026 12:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767960776; bh=L85XqhRnJ7U1d2xZzDxSAT0WPGAOdEmDlyJl+kbvYfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mDFJx/dInBEGOrdnR59X7yuFJn5g26oPU59qA+t8c22zqWym7WjOq6l5ipXTipcki diCyNfLbtntoNpu7pmSJ0JBLdr1S+jzsOs/9KTOKVz+NIX3VVbXNBWUr7NA4mDCkC8 OneDHuj9oQRHR3hCCQT+0Jb3rDCssDANnkVOkVh8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+3d43c9066a5b54902232@syzkaller.appspotmail.com, Deepanshu Kartikey , Andrew Lunn , Paolo Abeni , Sasha Levin Subject: [PATCH 6.6 521/737] net: usb: asix: validate PHY address before use Date: Fri, 9 Jan 2026 12:41:00 +0100 Message-ID: <20260109112153.600044850@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112133.973195406@linuxfoundation.org> References: <20260109112133.973195406@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Deepanshu Kartikey [ Upstream commit a1e077a3f76eea0dc671ed6792e7d543946227e8 ] The ASIX driver reads the PHY address from the USB device via asix_read_phy_addr(). A malicious or faulty device can return an invalid address (>= PHY_MAX_ADDR), which causes a warning in mdiobus_get_phy(): addr 207 out of range WARNING: drivers/net/phy/mdio_bus.c:76 Validate the PHY address in asix_read_phy_addr() and remove the now-redundant check in ax88172a.c. Reported-by: syzbot+3d43c9066a5b54902232@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3d43c9066a5b54902232 Tested-by: syzbot+3d43c9066a5b54902232@syzkaller.appspotmail.com Fixes: 7e88b11a862a ("net: usb: asix: refactor asix_read_phy_addr() and handle errors on return") Link: https://lore.kernel.org/all/20251217085057.270704-1-kartikey406@gmail.com/T/ [v1] Signed-off-by: Deepanshu Kartikey Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20251218011156.276824-1-kartikey406@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/usb/asix_common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 7fd763917ae2..6ab3486072cb 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c @@ -335,6 +335,11 @@ int asix_read_phy_addr(struct usbnet *dev, bool internal) offset = (internal ? 1 : 0); ret = buf[offset]; + if (ret >= PHY_MAX_ADDR) { + netdev_err(dev->net, "invalid PHY address: %d\n", ret); + return -ENODEV; + } + netdev_dbg(dev->net, "%s PHY address 0x%x\n", internal ? "internal" : "external", ret); -- 2.51.0