From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA75E35A94E; Fri, 9 Jan 2026 12:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767960943; cv=none; b=ehynxNVW/BlgNz17zZJl/Qf9mVYf+Us8XwDowhcFgA+MCyJHCDDr8hObGDjpjEmTrRP8bCpUK7wUTCWh2CqBZs3bGTUPia6e0H3l2sZx1uILXl3rNYNvy4JDJ3oT+BGALZhz232aZ6yzd1KN3GOwJq/6t/M6YpRlC/8cVeeR2nc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767960943; c=relaxed/simple; bh=zf7x272ZJ1cLbr04+OtYT/Y9K07IlyOVDJH/2agBkrw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VInz1GZwPN7mTKlhmHdu5ANCMQaFsC6iCiQwk8OAOZ8ryo0Ogt1wzxQqexhB7DxWcZzKxwGpAQw+Osum/IOggVdNz5dNkQDiT1H9fpy/18LktcxFBipMxhRRmeCCphGdJAVF6j72NReezkYA4A3i9urhWX8qw/KL8uRSZ7P4L2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=rowLtZN4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="rowLtZN4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EF93C4CEF1; Fri, 9 Jan 2026 12:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767960942; bh=zf7x272ZJ1cLbr04+OtYT/Y9K07IlyOVDJH/2agBkrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rowLtZN4bpjXGr1zwIg5Gn2UJxeoCA0lLU/zSrgZlVezn2to2EZOlKsxYdFoLxGWw CvkczWzwpqRsQ4o8dc+03lldKymCHnmgnbUuKrD7Xh7yvJawDXtPk4Z3wM4V9ReD7P rUCMKTgBiFiHIeimouTT7j5hKP2olFpRy0NuAQhM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ren=C3=A9=20Rebe?= , Helge Deller Subject: [PATCH 6.6 580/737] fbdev: gbefb: fix to use physical address instead of dma address Date: Fri, 9 Jan 2026 12:41:59 +0100 Message-ID: <20260109112155.818334057@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109112133.973195406@linuxfoundation.org> References: <20260109112133.973195406@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rene Rebe commit e3f44742bbb10537fe53d83d20dea2a7c167674d upstream. While debuggigng why X would not start on mips64 Sgi/O2 I found the phys adress being off. Turns out the gbefb passed the internal dma_addr as phys. May be broken pre git history. Fix by converting dma_to_phys. Signed-off-by: René Rebe Cc: # v4.0+ Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/gbefb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/gbefb.c +++ b/drivers/video/fbdev/gbefb.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -65,7 +66,7 @@ struct gbefb_par { static unsigned int gbe_mem_size = CONFIG_FB_GBE_MEM * 1024*1024; static void *gbe_mem; static dma_addr_t gbe_dma_addr; -static unsigned long gbe_mem_phys; +static phys_addr_t gbe_mem_phys; static struct { uint16_t *cpu; @@ -1182,7 +1183,7 @@ static int gbefb_probe(struct platform_d goto out_release_mem_region; } - gbe_mem_phys = (unsigned long) gbe_dma_addr; + gbe_mem_phys = dma_to_phys(&p_dev->dev, gbe_dma_addr); } par = info->par;