Re: [PATCH 6.6.y v2 1/4] nfsd: convert to new timestamp accessors

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Jan 08, 2026 at 02:09:59PM -0500, Chuck Lever wrote:
> From: Jeff Layton <jlayton@kernel.org>
> 
> [ Upstream commit 11fec9b9fb04fd1b3330a3b91ab9dcfa81ad5ad3 ]
> 
> Convert to using the new inode timestamp accessor functions.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> Link: https://lore.kernel.org/r/20231004185347.80880-50-jlayton@kernel.org
> Stable-dep-of: 24d92de9186e ("nfsd: Fix NFSv3 atomicity bugs in nfsd_setattr()")
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  fs/nfsd/blocklayout.c | 4 +++-
>  fs/nfsd/nfs3proc.c    | 4 ++--
>  fs/nfsd/nfs4proc.c    | 8 ++++----
>  fs/nfsd/nfsctl.c      | 2 +-
>  fs/nfsd/vfs.c         | 2 +-
>  5 files changed, 11 insertions(+), 9 deletions(-)

Adds a build warning, which breaks the build:

fs/nfsd/blocklayout.c: In function ‘nfsd4_block_commit_blocks’:
fs/nfsd/blocklayout.c:123:16: error: unused variable ‘new_size’ [-Werror=unused-variable]
  123 |         loff_t new_size = lcp->lc_last_wr + 1;
      |                ^~~~~~~~
cc1: all warnings being treated as errors

try a 3rd version?

thanks,

greg k-h