public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Matouš Lánský" <matouslansky@post.cz>,
	"Takashi Iwai" <tiwai@suse.de>, "Sasha Levin" <sashal@kernel.org>,
	sbinding@opensource.cirrus.com, kailang@realtek.com,
	chris.chiu@canonical.com, edip@medip.dev
Subject: [PATCH AUTOSEL 6.18-6.12] ALSA: hda/realtek: Add quirk for Acer Nitro AN517-55
Date: Mon, 12 Jan 2026 09:58:23 -0500	[thread overview]
Message-ID: <20260112145840.724774-22-sashal@kernel.org> (raw)
In-Reply-To: <20260112145840.724774-1-sashal@kernel.org>

From: Matouš Lánský <matouslansky@post.cz>

[ Upstream commit 9be25402d8522e16e5ebe84f2b1b6c5de082a388 ]

Add headset mic quirk for Acer Nitro AN517-55. This laptop uses
the same audio configuration as the AN515-58 model.

Signed-off-by: Matouš Lánský <matouslansky@post.cz>
Link: https://patch.msgid.link/20251231171207.76943-1-matouslansky@post.cz
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

## Commit Analysis: ALSA: hda/realtek: Add quirk for Acer Nitro AN517-55

### 1. COMMIT MESSAGE ANALYSIS

The commit adds a headset mic quirk for the Acer Nitro AN517-55 laptop.
The message clearly states this laptop uses the same audio configuration
as the AN515-58 model, which already has a quirk entry. The commit has
proper sign-offs from the submitter and the ALSA maintainer (Takashi
Iwai).

### 2. CODE CHANGE ANALYSIS

The change is a **single line addition** to the quirk table in
`sound/hda/codecs/realtek/alc269.c`:

```c
SND_PCI_QUIRK(0x1025, 0x1597, "Acer Nitro 5 AN517-55",
ALC2XX_FIXUP_HEADSET_MIC),
```

Breaking this down:
- `0x1025` - Acer's PCI vendor ID
- `0x1597` - Subsystem ID for the AN517-55 model
- `ALC2XX_FIXUP_HEADSET_MIC` - The fixup to enable headset microphone
  support

Looking at the context, the line immediately above is:
```c
SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58",
ALC2XX_FIXUP_HEADSET_MIC),
```

This confirms the AN517-55 uses the identical fixup as the AN515-58,
which is already proven to work.

### 3. CLASSIFICATION

This is a **HARDWARE QUIRK** - one of the explicitly allowed exceptions
for stable backports. It:
- Adds a PCI subsystem ID to an existing quirk table
- Uses an already-established fixup mechanism
- Does NOT add any new code logic or features

### 4. SCOPE AND RISK ASSESSMENT

- **Lines changed:** 1
- **Files touched:** 1
- **Complexity:** Trivial - table entry addition
- **Risk:** **Essentially zero** - This quirk entry ONLY affects devices
  with the exact PCI subsystem ID 0x1025:0x1597. It cannot possibly
  impact any other hardware.

### 5. USER IMPACT

- **Problem:** Headset microphone doesn't work on Acer Nitro AN517-55
  laptops without this quirk
- **Users affected:** Anyone with this specific laptop model who wants
  to use a headset with microphone
- **Severity:** This is a genuine hardware functionality bug - the mic
  input doesn't work without the quirk
- **Real-world impact:** Affects video calls, gaming chat, voice
  recording, etc.

### 6. STABILITY INDICATORS

- Signed off by Takashi Iwai (the ALSA maintainer)
- The `ALC2XX_FIXUP_HEADSET_MIC` fixup is well-established and used by
  many similar Acer models
- Pattern is identical to hundreds of other quirk entries in this file

### 7. DEPENDENCY CHECK

- **No dependencies** - the fixup being referenced already exists in
  stable kernels
- Will apply cleanly to any kernel with the HDA Realtek codec driver
- The quirk infrastructure has been stable for many years

## Conclusion

This is a **textbook stable backport candidate**:

1. **Fixes a real bug:** Headset mic doesn't work without it
2. **Obviously correct:** Identical to existing entry for similar
   hardware
3. **Small and contained:** Single line addition to a quirk table
4. **No new features:** Enables existing functionality for a new device
   ID
5. **Zero regression risk:** Only affects this specific laptop model
6. **Explicitly allowed:** Hardware quirks are called out as stable-
   appropriate in the rules

The stable kernel rules explicitly permit hardware quirks because they
fix real issues for specific hardware with essentially zero risk to
other systems. Users of this laptop on stable kernels would otherwise
have non-functional headset mic support until they upgrade to a newer
kernel.

**YES**

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index b3582e390dfa3..705d6acc204cf 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6239,6 +6239,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x1466, "Acer Aspire A515-56", ALC255_FIXUP_ACER_HEADPHONE_AND_MIC),
 	SND_PCI_QUIRK(0x1025, 0x1534, "Acer Predator PH315-54", ALC255_FIXUP_ACER_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1025, 0x159c, "Acer Nitro 5 AN515-58", ALC2XX_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x1025, 0x1597, "Acer Nitro 5 AN517-55", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1025, 0x169a, "Acer Swift SFG16", ALC256_FIXUP_ACER_SFG16_MICMUTE_LED),
 	SND_PCI_QUIRK(0x1025, 0x1826, "Acer Helios ZPC", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1025, 0x182c, "Acer Helios ZPD", ALC287_FIXUP_PREDATOR_SPK_CS35L41_I2C_2),
-- 
2.51.0


  parent reply	other threads:[~2026-01-12 14:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 14:58 [PATCH AUTOSEL 6.18] HID: Elecom: Add support for ELECOM M-XT3DRBK (018C) Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18] x86/sev: Disable GCOV on noinstr object Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] wifi: mac80211: collect station statistics earlier when disconnect Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18] btrfs: do not free data reservation in fallback from inline due to -ENOSPC Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] btrfs: fix deadlock in wait_current_trans() due to ignored transaction type Sasha Levin
2026-01-19 11:46   ` Motiejus Jakštys
2026-01-20 11:03     ` Greg KH
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] HID: quirks: Add another Chicony HP 5MP Cameras to hid_ignore_list Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.1] HID: intel-ish-hid: Update ishtp bus match to support device ID table Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] HID: multitouch: add MT_QUIRK_STICKY_FINGERS to MT_CLS_VTL Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.1] HID: i2c-hid: fix potential buffer overflow in i2c_hid_get_report() Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18] riscv: trace: fix snapshot deadlock with sbi ecall Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.12] drm/amd/pm: Disable MMIO access during SMU Mode 1 reset Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.12] riscv: Sanitize syscall table indexing under speculation Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.15] netfilter: replace -EEXIST with -EBUSY Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.12] PCI: qcom: Remove ASPM L0s support for MSM8996 SoC Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] ALSA: hda/realtek: add HP Laptop 15s-eq1xxx mute LED quirk Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] ring-buffer: Avoid softlockup in ring_buffer_resize() during memory free Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.15] HID: playstation: Center initial joystick axes to prevent spurious events Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] HID: intel-ish-hid: Reset enum_devices_done before enumeration Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18] drm/amd/display: Reduce number of arguments of dcn30's CalculatePrefetchSchedule() Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] HID: Apply quirk HID_QUIRK_ALWAYS_POLL to Edifier QR30 (2d99:a101) Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.1] btrfs: fix reservation leak in some error paths when inserting inline extent Sasha Levin
2026-01-12 14:58 ` Sasha Levin [this message]
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-6.12] HID: logitech: add HID++ support for Logitech MX Anywhere 3S Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18] HID: Intel-thc-hid: Intel-thc: Add safety check for reading DMA buffer Sasha Levin
2026-01-12 14:58 ` [PATCH AUTOSEL 6.18-5.10] HID: usbhid: paper over wrong bNumDescriptor field Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260112145840.724774-22-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=chris.chiu@canonical.com \
    --cc=edip@medip.dev \
    --cc=kailang@realtek.com \
    --cc=matouslansky@post.cz \
    --cc=patches@lists.linux.dev \
    --cc=sbinding@opensource.cirrus.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox