From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F58B3B8BB1; Thu, 15 Jan 2026 17:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768496901; cv=none; b=dHOQ5iq72DrcsUWMf4ZBJfhpZBm/ihHaG88Z494UsdfV8eYeUi0JTBDr+LpJheNp8T866YOYEcyTgLpF+ChNvy7w/zAs+6n0SRgs46ZazJVQxOawk5Zgz8m9i3eUpUpXIj54/flYih6EqA2rg1ufW+f7PCxqrK9mMfHh150S3pM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768496901; c=relaxed/simple; bh=22/DgDwqlo/kRIQdJDzKOK8nI9/V1ufWfTa9gxG6jqU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qDkCPDACjnrrSdowS7GM0QN3SxMbr/KIVltE39mQbTNaIf5AV3hvGWFosLOc2/vH3uGbN3IVm67kDdtDAhuBRrBX0ZR82bUdFLusY66j97u1LRHPQZ/mLvjQrvl7T5hUxAz5t7LPJRKuZWvxyeWiv02OvkoskqRPlGT1p9iZznM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uTeOJo4B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uTeOJo4B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB02FC116D0; Thu, 15 Jan 2026 17:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768496901; bh=22/DgDwqlo/kRIQdJDzKOK8nI9/V1ufWfTa9gxG6jqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uTeOJo4Bxq+WpmT4zuYKI6jkEmsZuUoW+NYzXwRZzn8SCIHChhKd8eII763HEwWdQ fR2EjEoMbshZ85aWvF1qRINKPYP1EVhD4s4FooF6bs60clFkBkTA3VJ6mbHdRdOWUb Jx8u4jQNs8HRAFqMBv5KKBqDVFT/UM4qo6kQt/lc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gal Pressman , Tariq Toukan , Mark Bloch , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 56/88] net/mlx5e: Dont print error message due to invalid module Date: Thu, 15 Jan 2026 17:48:39 +0100 Message-ID: <20260115164148.340856351@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164146.312481509@linuxfoundation.org> References: <20260115164146.312481509@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gal Pressman [ Upstream commit 144297e2a24e3e54aee1180ec21120ea38822b97 ] Dumping module EEPROM on newer modules is supported through the netlink interface only. Querying with old userspace ethtool (or other tools, such as 'lshw') which still uses the ioctl interface results in an error message that could flood dmesg (in addition to the expected error return value). The original message was added under the assumption that the driver should be able to handle all module types, but now that such flows are easily triggered from userspace, it doesn't serve its purpose. Change the log level of the print in mlx5_query_module_eeprom() to debug. Fixes: bb64143eee8c ("net/mlx5e: Add ethtool support for dump module EEPROM") Signed-off-by: Gal Pressman Reviewed-by: Tariq Toukan Signed-off-by: Mark Bloch Link: https://patch.msgid.link/20251225132717.358820-5-mbloch@nvidia.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c index 749f0fc2c189a..a5622b44385eb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c @@ -432,7 +432,8 @@ int mlx5_query_module_eeprom(struct mlx5_core_dev *dev, mlx5_qsfp_eeprom_params_set(&query.i2c_address, &query.page, &offset); break; default: - mlx5_core_err(dev, "Module ID not recognized: 0x%x\n", module_id); + mlx5_core_dbg(dev, "Module ID not recognized: 0x%x\n", + module_id); return -EINVAL; } -- 2.51.0