From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 617D52D7DED; Thu, 15 Jan 2026 17:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498961; cv=none; b=m2PxbfuKbSLUyPkNBv2HKI2hjvJNWd//7AoN1hZgZjZM89WgpQYNefxsGSUGpOLKGQEci3EE0FTbS3BL7Ih1IAO9wglCK1U0HbZtLvXHDjAzf9+ZjnxUrNQvP/NSz7ppsfV/D2pajcqjFLBwSGnNq6FFIuD0RSpvQ/640etf10I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498961; c=relaxed/simple; bh=Jfh5+zzP5M05YPBqQ5rrwk51IL9hhEHGlC5k2XHYqD4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lEg5KozRceJnhOGJDk2Qg4bkyUacd4tLMBK2a3jM60JKtr2RQbvjS5BoBcR4ipozhy+PLJ+wO8i7txY1K6ubISY5FHpjqXRZEM0S/XtOBUH1mwpEGggfgMQsm3rlhk5So4pomJftRbGPDeYbK5gF6elrqB7Z1g2neeIzbkzbqA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CNCVsE8S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CNCVsE8S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFF9EC116D0; Thu, 15 Jan 2026 17:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768498961; bh=Jfh5+zzP5M05YPBqQ5rrwk51IL9hhEHGlC5k2XHYqD4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CNCVsE8SXWO5qprfdmVcIzjoBRTet4g3y9/t66YVkZaID1ZbMV1d1uNuJ8529laKw 91G+VZjhjVFsU4ETVvkaqOZIr9uI04gymSp+PmmPt4W0kM8aZASU3gpripv5n6FJmR R7P2lfhTi+bE0F7aPzqpgKWl4NVBy/DKfyOyRrV4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shuhao Fu , Frank Li , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.10 052/451] i3c: fix refcount inconsistency in i3c_master_register Date: Thu, 15 Jan 2026 17:44:13 +0100 Message-ID: <20260115164232.781852936@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Frank Li [ Upstream commit 9d4f219807d5ac11fb1d596e4ddb09336b040067 ] In `i3c_master_register`, a possible refcount inconsistency has been identified, causing possible resource leak. Function `of_node_get` increases the refcount of `parent->of_node`. If function `i3c_bus_init` fails, the function returns immediately without a corresponding decrease, resulting in an inconsistent refcounter. Move call i3c_bus_init() after device_initialize() to let callback i3c_masterdev_release() release of_node. Reported-by: Shuhao Fu Closes: https://lore.kernel.org/linux-i3c/aO2tjp_FsV_WohPG@osx.local/T/#m2c05a982beeb14e7bf039c1d8db856734bf234c7 Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Frank Li Link: https://patch.msgid.link/20251016143814.2551256-1-Frank.Li@nxp.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/i3c/master.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 507fb6d26d330..527bea0ffcd7f 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -2661,10 +2661,6 @@ int i3c_master_register(struct i3c_master_controller *master, INIT_LIST_HEAD(&master->boardinfo.i2c); INIT_LIST_HEAD(&master->boardinfo.i3c); - ret = i3c_bus_init(i3cbus, master->dev.of_node); - if (ret) - return ret; - device_initialize(&master->dev); dev_set_name(&master->dev, "i3c-%d", i3cbus->id); @@ -2672,6 +2668,10 @@ int i3c_master_register(struct i3c_master_controller *master, master->dev.coherent_dma_mask = parent->coherent_dma_mask; master->dev.dma_parms = parent->dma_parms; + ret = i3c_bus_init(i3cbus, master->dev.of_node); + if (ret) + goto err_put_dev; + ret = of_populate_i3c_bus(master); if (ret) goto err_put_dev; -- 2.51.0