From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0372C0F83; Thu, 15 Jan 2026 17:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499041; cv=none; b=Ov4AHJjKFfg0mOHdxOrmIRgK4DZHGa2NjvuDe4KGDK/Ch7NUFl3yQ+QFDWp+/sX/nGHK5g+3KDPTvKWDqFsyVokn33EpB5ZyCfpCtBuPlXMv7so0oPQ1zpAiJUrNnYU6lmso3xiPDXJn9oyZ3VrmFt5afLrJCtRoCfEzLsemlP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499041; c=relaxed/simple; bh=XLLK01hOBPGplNCkIBlJuYSJw9kC1BxA7S2SEQhN9Lg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f68fttQA5mul/gYmoSiMFDDi4Vfybb+pvSvk7S4jujGa8oYKqjF0Bit0UG9EMyq7JGMp53sriEWkoDxABEuEpRT2q85pNnHH0pTSvZUTYbbNEAPE0f8pUu6vTlEYEsIFKaMpIQIDhBt/ewzAs8ei3vso8xONwIhQVj57smSJ7Qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dKCZ7Gvt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dKCZ7Gvt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF5AC116D0; Thu, 15 Jan 2026 17:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768499041; bh=XLLK01hOBPGplNCkIBlJuYSJw9kC1BxA7S2SEQhN9Lg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dKCZ7GvtGS7p1lU0zt2nS2cBEcz61qwi9fdyoRZvDDZO4GQ9ptHoigG03WlVWmpdf KGQac/Ms1Nab512I6oxfXAFGTYtBkDtNFJn9PGCdUNwGIhicCHop2mBPcnKH/Go/5n 4+x1lR+Uxkn5SFsJdBismzQwEh1Sqxm1GQNZrXxM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haotian Zhang , Lee Jones , Sasha Levin Subject: [PATCH 5.10 086/451] mfd: mt6397-irq: Fix missing irq_domain_remove() in error path Date: Thu, 15 Jan 2026 17:44:47 +0100 Message-ID: <20260115164234.028099358@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haotian Zhang [ Upstream commit b4b1bd1f330fdd13706382be6c90ce9f58cee3f5 ] If devm_request_threaded_irq() fails after irq_domain_create_linear() succeeds in mt6397_irq_init(), the function returns without removing the created IRQ domain, leading to a resource leak. Call irq_domain_remove() in the error path after a successful irq_domain_create_linear() to properly release the IRQ domain. Fixes: a4872e80ce7d ("mfd: mt6397: Extract IRQ related code from core driver") Signed-off-by: Haotian Zhang Link: https://patch.msgid.link/20251118121500.605-1-vulab@iscas.ac.cn Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mt6397-irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c index 2924919da991a..e1daed7edc841 100644 --- a/drivers/mfd/mt6397-irq.c +++ b/drivers/mfd/mt6397-irq.c @@ -206,6 +206,7 @@ int mt6397_irq_init(struct mt6397_chip *chip) if (ret) { dev_err(chip->dev, "failed to register irq=%d; err: %d\n", chip->irq, ret); + irq_domain_remove(chip->irq_domain); return ret; } -- 2.51.0