From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963F127A462; Thu, 15 Jan 2026 17:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499132; cv=none; b=Epozmpj08VXy4/T4hacEA4fyh6TLKRA9aGeN0EX302i2l6TBBjSm+Drto1W/ZWwfO6jopC43xu7GIA0HCBZClDq2CllH4ObB9FQJs/jGdo6f26H/qZHjL6xyw0gwyBgNgpwLldwE7zhb6ilpVFzbzgTvhN158vZF2vGmkBVqYMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499132; c=relaxed/simple; bh=090aMFQYoo+DHFGk4pN419ZL5K2T6OhValGnsnDFFyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uQl0/8tQv2zX/Nd1NAzfdMGGz0LKEqQBvRu7/4mmcPeQ60zTy6aSArP91okMn6Im17NxHkjm7IaQ38pVpALp4gR7qEVOqv3Gd/R5OSExUR56FJk07ucAV7f4gLi/u+U5BxvHF9RiIgqNJ2pdi6fU2TmyPPK+gHFqznaqTscNXEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TCns35/y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TCns35/y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21991C116D0; Thu, 15 Jan 2026 17:45:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768499132; bh=090aMFQYoo+DHFGk4pN419ZL5K2T6OhValGnsnDFFyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TCns35/yLJu+hn6WRWXFDZtZFaw0wfY38PwENg6iV3wRH/v7innB72e/8vbB6UWwL pzV65Z7jQEtAl2vO/cEfmqmQY0KmMRZr50pq7BHC2SLGHpqMMMA26zcp+JvlcJmaLm NGex/3Gz0/OCOae9Sr/heYbV5GJmlFv22T7kXoXE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haotian Zhang , Linus Walleij , Sasha Levin Subject: [PATCH 5.10 118/451] pinctrl: single: Fix incorrect type for error return variable Date: Thu, 15 Jan 2026 17:45:19 +0100 Message-ID: <20260115164235.192689232@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haotian Zhang [ Upstream commit 61d1bb53547d42c6bdaec9da4496beb3a1a05264 ] pcs_pinconf_get() and pcs_pinconf_set() declare ret as unsigned int, but assign it the return values of pcs_get_function() that may return negative error codes. This causes negative error codes to be converted to large positive values. Change ret from unsigned int to int in both functions. Fixes: 9dddb4df90d1 ("pinctrl: single: support generic pinconf") Signed-off-by: Haotian Zhang Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/pinctrl-single.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index bdcb5ede9b631..07bf090420453 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -490,7 +490,8 @@ static int pcs_pinconf_get(struct pinctrl_dev *pctldev, struct pcs_device *pcs = pinctrl_dev_get_drvdata(pctldev); struct pcs_function *func; enum pin_config_param param; - unsigned offset = 0, data = 0, i, j, ret; + unsigned offset = 0, data = 0, i, j; + int ret; ret = pcs_get_function(pctldev, pin, &func); if (ret) @@ -553,9 +554,9 @@ static int pcs_pinconf_set(struct pinctrl_dev *pctldev, { struct pcs_device *pcs = pinctrl_dev_get_drvdata(pctldev); struct pcs_function *func; - unsigned offset = 0, shift = 0, i, data, ret; + unsigned offset = 0, shift = 0, i, data; u32 arg; - int j; + int j, ret; enum pin_config_param param; ret = pcs_get_function(pctldev, pin, &func); -- 2.51.0