From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73722C11EF; Thu, 15 Jan 2026 17:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499698; cv=none; b=ZdIRIPHkVtD5jLIYgWlWORmxN/JtSZQTr6Wm4YhbsdKCI/wCldR6YqxgchDpdub2yhLphi6lXUj/QgP8ihnTp/66YM5H6bRQH4ZmDDyTDEfoS697JafVnZ687pGokT+VWx7KLLc3PZhoKyDgOVeDcFHGHeLroxUR/RYPzTeKvag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499698; c=relaxed/simple; bh=3tKNaUOwtp3kC2KGwCrx4dOuh4xL0y2n1fHfXhn3NAY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hXO9zQB7+Bc+5TPWTBKZDM3HTzmk4m5Oh3h6v6JE8fRDwiZlqIea6AIURi5oTe08oKJcdks86SXLI6BWX7cnwIpEJlY3AgfPAO1AvhsKYmhH0U/mnmwuFNk8gwFzu5pqP/fIvR/F8bcSAAnDnvq9v07CJevPrQKheDUIG8atlOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vnXtqYgj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vnXtqYgj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17634C116D0; Thu, 15 Jan 2026 17:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768499698; bh=3tKNaUOwtp3kC2KGwCrx4dOuh4xL0y2n1fHfXhn3NAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vnXtqYgjYlk72hyRghiT9DB8QRCSkOuxOlrqRr3sXFUdGduw9TquZ1R5Z/4xB6GGf /XjPxHUc7MWHN0GHjgNjm+9lb0EGKXT/BAMlHUiORaObhw6FUdlu0UUbWpJCUHRtvQ SrF1BIm6bqJeEOUt8agCb6RIaD1iEuutMVmRhj6E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ren=C3=A9=20Rebe?= , Helge Deller Subject: [PATCH 5.10 319/451] fbdev: gbefb: fix to use physical address instead of dma address Date: Thu, 15 Jan 2026 17:48:40 +0100 Message-ID: <20260115164242.439696485@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rene Rebe commit e3f44742bbb10537fe53d83d20dea2a7c167674d upstream. While debuggigng why X would not start on mips64 Sgi/O2 I found the phys adress being off. Turns out the gbefb passed the internal dma_addr as phys. May be broken pre git history. Fix by converting dma_to_phys. Signed-off-by: René Rebe Cc: # v4.0+ Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/gbefb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/video/fbdev/gbefb.c +++ b/drivers/video/fbdev/gbefb.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -65,7 +66,7 @@ struct gbefb_par { static unsigned int gbe_mem_size = CONFIG_FB_GBE_MEM * 1024*1024; static void *gbe_mem; static dma_addr_t gbe_dma_addr; -static unsigned long gbe_mem_phys; +static phys_addr_t gbe_mem_phys; static struct { uint16_t *cpu; @@ -1189,7 +1190,7 @@ static int gbefb_probe(struct platform_d goto out_release_mem_region; } - gbe_mem_phys = (unsigned long) gbe_dma_addr; + gbe_mem_phys = dma_to_phys(&p_dev->dev, gbe_dma_addr); } par = info->par;