From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B143D6473; Thu, 15 Jan 2026 17:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499743; cv=none; b=tHDNpNxm5XjtLnqcOAi+TslHD0kZMupEzIQBTLpxYhzOoiNhjiSt1p8CWy8q/N/RBeevBpv6Pb8IE+TigIekc4e27fbOGZ7kgdE0fwix3DVnhdtyJjdg5vDvGZrvJGPd0SVQwws3GQvyqUfZuKrd4Ape9C4PU9VrH4RZpfljZMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499743; c=relaxed/simple; bh=6rjsZA0XxO2uRBhMpMEFVEUIQawBDwxp5T5TSQOcGew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uxZ9Gt1vqTZa1KaC6CnQfU6jPRuPwz97NDF+/dpXD0YINgVJIa5EsKakZ6qEhCsUDP1B9whG6/ddcvcrOaLslXMtY4RL7eVPpF/bK291Pq0vcpQTNASzgqgomylyBUX44lVpW0gxkQOMolaso3FSiG1fcwoKBnnCYwPMw1NFEEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=K4OoV5/f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="K4OoV5/f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FB0AC116D0; Thu, 15 Jan 2026 17:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768499743; bh=6rjsZA0XxO2uRBhMpMEFVEUIQawBDwxp5T5TSQOcGew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K4OoV5/fFqDM60Ah91b+UB4/lHB5ROkvE8TMXUWkpieYMmqjFAUtL44SXDi2DsPs+ CCd/3PTNum3Q8tqjl/IUIfResFwiAanN4jm2Ifk5RS5+ZfFH3UWK02dS+kdRTrx/TU XF7UnO+2qhq2/SBU8rdX+XK9ObNh8lwzdf/tYwaA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ethan Nelson-Moore , Paolo Abeni Subject: [PATCH 5.10 333/451] net: usb: sr9700: fix incorrect command used to write single register Date: Thu, 15 Jan 2026 17:48:54 +0100 Message-ID: <20260115164242.942066967@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ethan Nelson-Moore commit fa0b198be1c6775bc7804731a43be5d899d19e7a upstream. This fixes the device failing to initialize with "error reading MAC address" for me, probably because the incorrect write of NCR_RST to SR_NCR is not actually resetting the device. Fixes: c9b37458e95629b1d1171457afdcc1bf1eb7881d ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support") Cc: stable@vger.kernel.org Signed-off-by: Ethan Nelson-Moore Link: https://patch.msgid.link/20251221082400.50688-1-enelsonmoore@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/sr9700.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -52,7 +52,7 @@ static int sr_read_reg(struct usbnet *de static int sr_write_reg(struct usbnet *dev, u8 reg, u8 value) { - return usbnet_write_cmd(dev, SR_WR_REGS, SR_REQ_WR_REG, + return usbnet_write_cmd(dev, SR_WR_REG, SR_REQ_WR_REG, value, reg, NULL, 0); } @@ -64,7 +64,7 @@ static void sr_write_async(struct usbnet static void sr_write_reg_async(struct usbnet *dev, u8 reg, u8 value) { - usbnet_write_cmd_async(dev, SR_WR_REGS, SR_REQ_WR_REG, + usbnet_write_cmd_async(dev, SR_WR_REG, SR_REQ_WR_REG, value, reg, NULL, 0); }