From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347503D331F; Thu, 15 Jan 2026 17:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499857; cv=none; b=VQ4yf25s6FIrhjSJjFJZg4fSIPThHqKc8ei5Gurcaf9jIHK2ycs9EhUQqazZ3dx32STYVSSVPGx6UTmZQImk0JbqXeA5lmrVP1HItY4bw5WU+46V3iNcyGgsmW8blcTxN+zIy4i6mpKQoCfQGzdZMB2q694/XOKqLNBX6kLw5HE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768499857; c=relaxed/simple; bh=pnzRgEqignujfM1ByiWLkI+eeyOlt0eC027i8jJhvLM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kFQJri9ulsewuDWYh1EbPcj9PKwYxnKPe3sU0cE+PjprDRMa9isOigJlOGR7SAJ7ul/47CzDx/h8bMZJDuy4gavZS6rqO7zY8qUDgZUxI7lAwAMVArP0poaEgZxlVJZTRTUKG784qb2FEV7cCsIZW0vlFZWz7Ub0FaTD5HZZU2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MCSslz6A; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MCSslz6A" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8D98C116D0; Thu, 15 Jan 2026 17:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768499857; bh=pnzRgEqignujfM1ByiWLkI+eeyOlt0eC027i8jJhvLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MCSslz6Aq/qBYjgz7L/LhEbah6N4MQP4cikUxhhMW/60Hi0w2lBkhiW7ZlRXkeDTa qgixjat/Vc1aWNrRUd8JMxvNoi1E0qsN67fdd2peLGGzzB+6rqRf4bPRrCN66wvKE9 7izkkkeqM72aJg/PPMRWY8ji0HFSgMzWczVM3tVo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gui-Dong Han , Guenter Roeck , Sasha Levin Subject: [PATCH 5.10 372/451] hwmon: (max16065) Use local variable to avoid TOCTOU Date: Thu, 15 Jan 2026 17:49:33 +0100 Message-ID: <20260115164244.371233832@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gui-Dong Han [ Upstream commit b8d5acdcf525f44e521ca4ef51dce4dac403dab4 ] In max16065_current_show, data->curr_sense is read twice: once for the error check and again for the calculation. Since i2c_smbus_read_byte_data returns negative error codes on failure, if the data changes to an error code between the check and the use, ADC_TO_CURR results in an incorrect calculation. Read data->curr_sense into a local variable to ensure consistency. Note that data->curr_gain is constant and safe to access directly. This aligns max16065_current_show with max16065_input_show, which already uses a local variable for the same reason. Link: https://lore.kernel.org/all/CALbr=LYJ_ehtp53HXEVkSpYoub+XYSTU8Rg=o1xxMJ8=5z8B-g@mail.gmail.com/ Fixes: f5bae2642e3d ("hwmon: Driver for MAX16065 System Manager and compatibles") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han Link: https://lore.kernel.org/r/20251128124709.3876-1-hanguidong02@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/max16065.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/hwmon/max16065.c +++ b/drivers/hwmon/max16065.c @@ -216,12 +216,13 @@ static ssize_t max16065_current_show(str struct device_attribute *da, char *buf) { struct max16065_data *data = max16065_update_device(dev); + int curr_sense = data->curr_sense; - if (unlikely(data->curr_sense < 0)) - return data->curr_sense; + if (unlikely(curr_sense < 0)) + return curr_sense; return sysfs_emit(buf, "%d\n", - ADC_TO_CURR(data->curr_sense, data->curr_gain)); + ADC_TO_CURR(curr_sense, data->curr_gain)); } static ssize_t max16065_limit_store(struct device *dev,