From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34FFF3E95A1; Thu, 15 Jan 2026 18:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768500029; cv=none; b=EFI7SgjFPkfIxVqPuWoZpCRThi39A1hP7f/bJLED3vzy1JIi5iWBzrBKVuw56Nv4F+ifAdY3xTZc85+2mOc2i81YA4a64O8ewAvhVh94YeN1Js8aQrTR5DfB73cSLfAXx+d9kgI1x+T0TE9LFnnQtZfMicqsPiC6HkSFPrkeQY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768500029; c=relaxed/simple; bh=pguJ2BWRSeULrODFeP9SbmklGsQqx8Bz+4LGcYKcPPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T0utwUF0CfwM6MstEr72ZksT5T10Te5hNKb34+vJsZFfrOrMcgRm1FK3ZODEsCzHKKRSoybNCM+typhWPqnkphybBjLS5Z03aO3j7ooRX5bsr+eZZ6bcYaL1NQAVQAjpYVRygqQgyxBGmBz3aRmI89RMeekgamhnBYth0Rl8JYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EEwF2Jmm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EEwF2Jmm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0B0C116D0; Thu, 15 Jan 2026 18:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768500029; bh=pguJ2BWRSeULrODFeP9SbmklGsQqx8Bz+4LGcYKcPPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EEwF2Jmm+Yn7gbhuiXXje+2Ld6gW7M+xKzclECLHtB/upN2Q8hq1XNkL0VufiMBBH c1BklzHVbkIqhuAKEr7mkRM44whZRgiF5LREoifhbpEWQejWBjnw/iYGmoVUH6S37f 8HcJkvLs4B97z619s+UxEProKvzrAJXMWg1yeNaU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fernando Fernandez Mancera , Florian Westphal , Sasha Levin Subject: [PATCH 5.10 433/451] netfilter: nf_conncount: update last_gc only when GC has been performed Date: Thu, 15 Jan 2026 17:50:34 +0100 Message-ID: <20260115164246.611676618@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164230.864985076@linuxfoundation.org> References: <20260115164230.864985076@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fernando Fernandez Mancera [ Upstream commit 7811ba452402d58628e68faedf38745b3d485e3c ] Currently last_gc is being updated everytime a new connection is tracked, that means that it is updated even if a GC wasn't performed. With a sufficiently high packet rate, it is possible to always bypass the GC, causing the list to grow infinitely. Update the last_gc value only when a GC has been actually performed. Fixes: d265929930e2 ("netfilter: nf_conncount: reduce unnecessary GC") Signed-off-by: Fernando Fernandez Mancera Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/netfilter/nf_conncount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conncount.c b/net/netfilter/nf_conncount.c index c00b8e522c5a7..a2c5a7ba0c6fc 100644 --- a/net/netfilter/nf_conncount.c +++ b/net/netfilter/nf_conncount.c @@ -229,6 +229,7 @@ static int __nf_conncount_add(struct net *net, nf_ct_put(found_ct); } + list->last_gc = (u32)jiffies; add_new_node: if (WARN_ON_ONCE(list->count > INT_MAX)) { @@ -248,7 +249,6 @@ static int __nf_conncount_add(struct net *net, conn->jiffies32 = (u32)jiffies; list_add_tail(&conn->node, &list->head); list->count++; - list->last_gc = (u32)jiffies; out_put: if (refcounted) -- 2.51.0