From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2104D3C009A; Thu, 15 Jan 2026 17:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498198; cv=none; b=Yk73sahuXW2bxKnmSQRQ/804/duHN9n5QCryWrUZNIresj6Xkbez0UggHZm2Yr9GKrY0tGE8qwMTfYvz20xQK9ZBbINjPIyiI4At1zSEPh6JQEiZFZGBQtWTWzBfz0h4mcXvT8ik3qIZpQ/1pHbOUluXbrEaIPVHYdvcyzmY3g8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768498198; c=relaxed/simple; bh=SC5ZHa0tYp0NWCwCJGbs1gB6cRQ2jD9mVuENi9AJ6F4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GrCwcBXP51pWGIaiZKdMRHuahIfDhxJ/dRb9T34FnirsKl1Tt61/GeZ0v+gazhemEM7mK1KdZik24oU2WKNdCqBp3Ofwhhaeu5MYxVB98BBIBd/lY76aHSiAw1dodVZkQ9O5ywVwY5ES/Telrq8u4DFNOBjzjlFEiPAlHMWbqOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0bkO6qKU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0bkO6qKU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2B0DC116D0; Thu, 15 Jan 2026 17:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768498198; bh=SC5ZHa0tYp0NWCwCJGbs1gB6cRQ2jD9mVuENi9AJ6F4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0bkO6qKU8826CX9BgRLGRseDlpM9n6pt9ToDSHmGJgW71QCmOvbr90ZFLIZqTWCns ltAUY7N9KeboqTvp24NSJSq4xahUapYN/hewoUY1NYDlycl0KgjjANLDEJyGU0IElv rwksBcCy6eKsHEEMuFUF1mOFoNA+Z04IjdSf1+fQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 5.15 346/554] platform/x86: msi-laptop: add missing sysfs_remove_group() Date: Thu, 15 Jan 2026 17:46:52 +0100 Message-ID: <20260115164258.752933831@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115164246.225995385@linuxfoundation.org> References: <20260115164246.225995385@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit 1461209cf813b6ee6d40f29b96b544587df6d2b1 ] A sysfs group is created in msi_init() when old_ec_model is enabled, but never removed. Remove the msipf_old_attribute_group in that case. Fixes: 03696e51d75a ("msi-laptop: Disable brightness control for new EC") Signed-off-by: Thomas Fourier Link: https://patch.msgid.link/20251217103617.27668-2-fourier.thomas@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/msi-laptop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c index dfb4af759aa7..fd6b3383ac4f 100644 --- a/drivers/platform/x86/msi-laptop.c +++ b/drivers/platform/x86/msi-laptop.c @@ -1146,6 +1146,9 @@ static void __exit msi_cleanup(void) sysfs_remove_group(&msipf_device->dev.kobj, &msipf_attribute_group); if (!quirks->old_ec_model && threeg_exists) device_remove_file(&msipf_device->dev, &dev_attr_threeg); + if (quirks->old_ec_model) + sysfs_remove_group(&msipf_device->dev.kobj, + &msipf_old_attribute_group); platform_device_unregister(msipf_device); platform_driver_unregister(&msipf_driver); backlight_device_unregister(msibl_device); -- 2.51.0