From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Benson Leung <bleung@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linusw@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev, linux-kselftest@vger.kernel.org,
tzungbi@kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Simona Vetter <simona.vetter@ffwll.ch>,
Dan Williams <dan.j.williams@intel.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-gpio@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 04/23] gpiolib: Fix resource leaks on errors in lineinfo_changed_notify()
Date: Fri, 16 Jan 2026 08:10:17 +0000 [thread overview]
Message-ID: <20260116081036.352286-5-tzungbi@kernel.org> (raw)
In-Reply-To: <20260116081036.352286-1-tzungbi@kernel.org>
On error handling paths, lineinfo_changed_notify() doesn't free the
allocated resources which results leaks. Fix it.
Cc: stable@vger.kernel.org
Fixes: d4cd0902c156 ("gpio: cdev: make sure the cdev fd is still active before emitting events")
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
drivers/gpio/gpiolib-cdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index ba1eae15852d..6196aab5ed74 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -2549,7 +2549,7 @@ static int lineinfo_changed_notify(struct notifier_block *nb,
ctx = kzalloc(sizeof(*ctx), GFP_ATOMIC);
if (!ctx) {
pr_err("Failed to allocate memory for line info notification\n");
- return NOTIFY_DONE;
+ goto err_put_fp;
}
ctx->chg.event_type = action;
@@ -2563,6 +2563,9 @@ static int lineinfo_changed_notify(struct notifier_block *nb,
queue_work(ctx->gdev->line_state_wq, &ctx->work);
return NOTIFY_OK;
+err_put_fp:
+ fput(fp);
+ return NOTIFY_DONE;
}
static int gpio_device_unregistered_notify(struct notifier_block *nb,
--
2.52.0.457.g6b5491de43-goog
next prev parent reply other threads:[~2026-01-16 8:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260116081036.352286-1-tzungbi@kernel.org>
2026-01-16 8:10 ` [PATCH 01/23] gpiolib: Correct wrong kfree() usage for `kobj->name` Tzung-Bi Shih
2026-01-16 13:15 ` Bartosz Golaszewski
2026-01-16 13:27 ` Greg Kroah-Hartman
2026-01-16 13:30 ` Bartosz Golaszewski
2026-01-20 4:29 ` Tzung-Bi Shih
2026-01-16 14:13 ` Jason Gunthorpe
2026-01-16 14:38 ` Bartosz Golaszewski
2026-01-20 4:30 ` Tzung-Bi Shih
2026-01-20 9:43 ` Bartosz Golaszewski
2026-01-16 8:10 ` [PATCH 02/23] gpiolib: cdev: Fix resource leaks on errors in gpiolib_cdev_register() Tzung-Bi Shih
2026-01-20 8:50 ` Bartosz Golaszewski
2026-01-20 9:34 ` Tzung-Bi Shih
2026-01-20 9:39 ` Bartosz Golaszewski
2026-01-16 8:10 ` [PATCH 03/23] gpiolib: Fix resource leaks on errors in gpiochip_add_data_with_key() Tzung-Bi Shih
2026-01-16 8:10 ` Tzung-Bi Shih [this message]
2026-01-16 13:26 ` [PATCH 04/23] gpiolib: Fix resource leaks on errors in lineinfo_changed_notify() Bartosz Golaszewski
2026-01-20 3:11 ` Tzung-Bi Shih
2026-01-20 8:49 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116081036.352286-5-tzungbi@kernel.org \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=chrome-platform@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linusw@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox