From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: tip-bot2 for Oleg Nesterov <tip-bot2@linutronix.de>,
linux-tip-commits@vger.kernel.org,
Paulo Andrade <pandrade@redhat.com>,
stable@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [tip: perf/core] x86/uprobes: Fix XOL allocation failure for 32-bit tasks
Date: Fri, 16 Jan 2026 11:41:27 +0100 [thread overview]
Message-ID: <20260116104127.GA1890602@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aWoMN5oCPIl2M2DP@redhat.com>
On Fri, Jan 16, 2026 at 11:00:23AM +0100, Oleg Nesterov wrote:
> On 01/15, tip-bot2 for Oleg Nesterov wrote:
> >
> > The following commit has been merged into the perf/core branch of tip:
>
> Damn!
>
> thanks Peter, but...
>
> > --- a/arch/x86/kernel/uprobes.c
> > +++ b/arch/x86/kernel/uprobes.c
> > @@ -1823,3 +1823,27 @@ bool is_uprobe_at_func_entry(struct pt_regs *regs)
> >
> > return false;
> > }
> > +
> > +#ifdef CONFIG_IA32_EMULATION
> > +unsigned long __weak arch_uprobe_get_xol_area(void)
>
> Oh, but x86 version should not be __weak. Copy-and-paste error, sorry :/
>
> What do you want me to do now,
>
> - send V2 ?
>
> - send another s/__weak// patch on top of this hack?
>
> - or perhaps you can fix this yourself?
I'll have to rebase anyway, might as well fix it directly.
Thanks!
next prev parent reply other threads:[~2026-01-16 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aWO7Fdxn39piQnxu@redhat.com>
2026-01-15 21:43 ` [tip: perf/core] x86/uprobes: Fix XOL allocation failure for 32-bit tasks tip-bot2 for Oleg Nesterov
2026-01-16 10:00 ` Oleg Nesterov
2026-01-16 10:41 ` Peter Zijlstra [this message]
2026-01-16 10:49 ` tip-bot2 for Oleg Nesterov
2026-01-16 15:27 ` tip-bot2 for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116104127.GA1890602@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pandrade@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tip-bot2@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox