From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAEB723EA85; Fri, 16 Jan 2026 14:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768574865; cv=none; b=gASRSgqvB9E5YzPd+4cz8EbxOynw14yH3LRLV4/d1+GUUINQXPkxRRJu5OelcouMlcvCbAzo5oB10lRGOxxxKOWaQv+vsqaxGFuuvtr1RQnUYOdjrdLqj3AsMLfcSFR3b5oA26dMGeNwuP41DOy6pVMSRyBN9dAqjTj/fQfE58I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768574865; c=relaxed/simple; bh=NmY6f/3++srymFtkQFv5iqmHppCm9HzuPAroq8sLV+0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rOTsqSCVIv+avP+ngphiEW822CmW1qppUclWA9Ecezk6XVKk9r3/PGZgRWsy2xoT2Z7Vm9snQmUZpdCSJLQhz+uO9NJyOvqdrRnuHX/yN+2D2eAb6LJDwT7xgOr/cLMDan4zJg75m1X9yGWyudGAuKabqPKGvNGubkmJhwfT7LU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pOm744By; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pOm744By" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09282C116C6; Fri, 16 Jan 2026 14:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1768574865; bh=NmY6f/3++srymFtkQFv5iqmHppCm9HzuPAroq8sLV+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pOm744ByqRtqzwg0ncDID5yzmiFLYAyfuZQnFxz1nUOfRZyNZpG74HHT07eF7XE4n 7txNc0cHhHmobnzxhK21mhoXFsVYN04TNz0MtNeftlGzBDJWxjRVdcN7NFCZhKg5QL krSGx/52Mki3qjBaCiRe6opdag4NRJ8RYTxEL/VE= Date: Fri, 16 Jan 2026 15:47:42 +0100 From: Greg KH To: Xingjing Deng Cc: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Xingjing Deng , stable@vger.kernel.org Subject: Re: [PATCH v4] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe Message-ID: <2026011637-statute-showy-2c3f@gregkh> References: <20260113143445.889031-1-xjdeng@buaa.edu.cn> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260113143445.889031-1-xjdeng@buaa.edu.cn> On Tue, Jan 13, 2026 at 10:34:45PM +0800, Xingjing Deng wrote: > In the SDSP probe path, qcom_scm_assign_mem() is used to assign the > reserved memory to the configured VMIDs, but its return value was not > checked. > > Fail the probe if the SCM call fails to avoid continuing with an > unexpected/incorrect memory permission configuration > > Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access to the DSP") > Cc: stable@vger.kernel.org # 6.11-rc1 > Signed-off-by: Xingjing Deng > > --- > > v4: > - Format the indentation > - Link to v3: https://lore.kernel.org/linux-arm-msm/20260113084352.72itrloj5w7qb5o3@hu-mojha-hyd.qualcomm.com/T/#t > > v3: > - Add missing linux-kernel@vger.kernel.org to cc list. > - Standarlize changelog placement/format. > - Link to v2: https://lore.kernel.org/linux-arm-msm/20260113063618.e2ke47gy3hnfi67e@hu-mojha-hyd.qualcomm.com/T/#t > > v2: > - Add Fixes: and Cc: stable tags. > - Link to v1: https://lore.kernel.org/linux-arm-msm/20260113022550.4029635-1-xjdeng@buaa.edu.cn/T/#u > > Signed-off-by: Xingjing Deng > --- > drivers/misc/fastrpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index cbb12db110b3..9c41b51d80ee 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -2339,10 +2339,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) > src_perms = BIT(QCOM_SCM_VMID_HLOS); > > err = qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, > - data->vmperms, data->vmcount); > + data->vmperms, data->vmcount); I'm all for coding style cleanups, but don't mix that into a patch that does something else. Also, please indent this properly, checkpatch should complain about this. > if (err) { > dev_err(rdev, "Failed to assign memory phys 0x%llx size 0x%llx err %d", > - res.start, resource_size(&res), err); > + res.start, resource_size(&res), err); Same here, that's not right. And I don't see the real change here, are you sure you generated this properly? This just looks like coding style cleanups, which do not match the changelog text. thanks, greg k-h