From: Jakub Kicinski <kuba@kernel.org>
To: Paul Moses <p@1g4.org>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v1 3/3] net/sched: act_gate: zero-initialize netlink dump struct
Date: Mon, 19 Jan 2026 11:14:52 -0800 [thread overview]
Message-ID: <20260119111452.37dde230@kernel.org> (raw)
In-Reply-To: <20260116112522.159480-4-p@1g4.org>
On Fri, 16 Jan 2026 11:26:08 +0000 Paul Moses wrote:
> - unsigned char *b = skb_tail_pointer(skb);
> struct tcf_gate *gact = to_gate(a);
> - struct tc_gate opt = {
> - .index = gact->tcf_index,
> - .refcnt = refcount_read(&gact->tcf_refcnt) - ref,
> - .bindcnt = atomic_read(&gact->tcf_bindcnt) - bind,
> - };
> struct tcfg_gate_entry *entry;
> struct tcf_gate_params *p;
> struct nlattr *entry_list;
> + struct tc_gate opt = { };
> struct tcf_t t;
> + unsigned char *b = skb_tail_pointer(skb);
Why is *b moving? Please avoid unnecessary code changes in fixes.
Also -- we prefer the declaration lines to be sorted longest to
shortest. If a dependency prevents that the init needs to be moved
to the body of the function (this mostly applies to patch 2).
prev parent reply other threads:[~2026-01-19 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260116112522.159480-1-p@1g4.org>
2026-01-16 11:26 ` [PATCH net v1 2/3] net/sched: act_gate: fix schedule updates with RCU swap Paul Moses
2026-01-19 19:12 ` [net,v1,2/3] " Jakub Kicinski
2026-01-16 11:26 ` [PATCH net v1 3/3] net/sched: act_gate: zero-initialize netlink dump struct Paul Moses
2026-01-19 19:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119111452.37dde230@kernel.org \
--to=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p@1g4.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox