* [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a
@ 2026-01-19 3:45 Qin Wan
2026-01-19 6:37 ` Greg KH
2026-01-19 8:19 ` Takashi Iwai
0 siblings, 2 replies; 4+ messages in thread
From: Qin Wan @ 2026-01-19 3:45 UTC (permalink / raw)
To: perex, tiwai, sbinding, kailang, chris.chiu, edip
Cc: linux-sound, linux-kernel, stable, alexandru.gagniuc, Qin Wan,
Alexandru Gagniuc
This laptop uses the ALC236 codec, fixed by enabling
the ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk
Signed-off-by: Qin Wan <qin.wan@hp.com>
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
sound/hda/codecs/realtek/alc269.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 0bd9fe745807..49590926199e 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6704,6 +6704,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8ed8, "HP Merino16", ALC245_FIXUP_TAS2781_SPI_2),
SND_PCI_QUIRK(0x103c, 0x8ed9, "HP Merino14W", ALC245_FIXUP_TAS2781_SPI_2),
SND_PCI_QUIRK(0x103c, 0x8eda, "HP Merino16W", ALC245_FIXUP_TAS2781_SPI_2),
+ SND_PCI_QUIRK(0x103c, 0x8f14, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8f19, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8f3c, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8f3d, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8f40, "HP Lampas14", ALC287_FIXUP_TXNW2781_I2C),
SND_PCI_QUIRK(0x103c, 0x8f41, "HP Lampas16", ALC287_FIXUP_TXNW2781_I2C),
SND_PCI_QUIRK(0x103c, 0x8f42, "HP LampasW14", ALC287_FIXUP_TXNW2781_I2C),
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a
2026-01-19 3:45 [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a Qin Wan
@ 2026-01-19 6:37 ` Greg KH
2026-01-19 8:19 ` Takashi Iwai
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-01-19 6:37 UTC (permalink / raw)
To: Qin Wan
Cc: perex, tiwai, sbinding, kailang, chris.chiu, edip, linux-sound,
linux-kernel, stable, alexandru.gagniuc, Alexandru Gagniuc
On Mon, Jan 19, 2026 at 11:45:04AM +0800, Qin Wan wrote:
> This laptop uses the ALC236 codec, fixed by enabling
> the ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk
>
> Signed-off-by: Qin Wan <qin.wan@hp.com>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> ---
> sound/hda/codecs/realtek/alc269.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 0bd9fe745807..49590926199e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6704,6 +6704,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8ed8, "HP Merino16", ALC245_FIXUP_TAS2781_SPI_2),
> SND_PCI_QUIRK(0x103c, 0x8ed9, "HP Merino14W", ALC245_FIXUP_TAS2781_SPI_2),
> SND_PCI_QUIRK(0x103c, 0x8eda, "HP Merino16W", ALC245_FIXUP_TAS2781_SPI_2),
> + SND_PCI_QUIRK(0x103c, 0x8f14, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f19, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f3c, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f3d, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8f40, "HP Lampas14", ALC287_FIXUP_TXNW2781_I2C),
> SND_PCI_QUIRK(0x103c, 0x8f41, "HP Lampas16", ALC287_FIXUP_TXNW2781_I2C),
> SND_PCI_QUIRK(0x103c, 0x8f42, "HP LampasW14", ALC287_FIXUP_TXNW2781_I2C),
> --
> 2.43.0
>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a
2026-01-19 3:45 [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a Qin Wan
2026-01-19 6:37 ` Greg KH
@ 2026-01-19 8:19 ` Takashi Iwai
2026-01-19 9:23 ` 回复: " Wan, Qin (Thin Client RnD)
1 sibling, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2026-01-19 8:19 UTC (permalink / raw)
To: Qin Wan
Cc: perex, tiwai, sbinding, kailang, chris.chiu, edip, linux-sound,
linux-kernel, stable, alexandru.gagniuc, Alexandru Gagniuc
On Mon, 19 Jan 2026 04:45:04 +0100,
Qin Wan wrote:
>
> This laptop uses the ALC236 codec, fixed by enabling
> the ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk
>
> Signed-off-by: Qin Wan <qin.wan@hp.com>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
The patch isn't applicable cleanly at all, as you have lots of
different quirk entries. Which git tree is it based on?
thanks,
Takashi
> ---
> sound/hda/codecs/realtek/alc269.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 0bd9fe745807..49590926199e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6704,6 +6704,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8ed8, "HP Merino16", ALC245_FIXUP_TAS2781_SPI_2),
> SND_PCI_QUIRK(0x103c, 0x8ed9, "HP Merino14W", ALC245_FIXUP_TAS2781_SPI_2),
> SND_PCI_QUIRK(0x103c, 0x8eda, "HP Merino16W", ALC245_FIXUP_TAS2781_SPI_2),
> + SND_PCI_QUIRK(0x103c, 0x8f14, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f19, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f3c, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f3d, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8f40, "HP Lampas14", ALC287_FIXUP_TXNW2781_I2C),
> SND_PCI_QUIRK(0x103c, 0x8f41, "HP Lampas16", ALC287_FIXUP_TXNW2781_I2C),
> SND_PCI_QUIRK(0x103c, 0x8f42, "HP LampasW14", ALC287_FIXUP_TXNW2781_I2C),
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a
2026-01-19 8:19 ` Takashi Iwai
@ 2026-01-19 9:23 ` Wan, Qin (Thin Client RnD)
0 siblings, 0 replies; 4+ messages in thread
From: Wan, Qin (Thin Client RnD) @ 2026-01-19 9:23 UTC (permalink / raw)
To: Takashi Iwai
Cc: perex@perex.cz, tiwai@suse.com, sbinding@opensource.cirrus.com,
kailang@realtek.com, chris.chiu@canonical.com, edip@medip.dev,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Gagniuc, Alexandru, Alexandru Gagniuc
[-- Attachment #1: Type: text/plain, Size: 2664 bytes --]
Hello,
I corrected the patch based on mainline and add stable tag.
Thanks,
Wanqin
________________________________________
发件人: Takashi Iwai <tiwai@suse.de>
已发送: 2026 年 1 月 19 日 星期一 16:19
收件人: Wan, Qin (Thin Client RnD) <qin.wan@hp.com>
抄送: perex@perex.cz <perex@perex.cz>; tiwai@suse.com <tiwai@suse.com>; sbinding@opensource.cirrus.com <sbinding@opensource.cirrus.com>; kailang@realtek.com <kailang@realtek.com>; chris.chiu@canonical.com <chris.chiu@canonical.com>; edip@medip.dev <edip@medip.dev>; linux-sound@vger.kernel.org <linux-sound@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; stable@vger.kernel.org <stable@vger.kernel.org>; Gagniuc, Alexandru <alexandru.gagniuc@hp.com>; Alexandru Gagniuc <mr.nuke.me@gmail.com>
主题: Re: [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a
CAUTION: External Email
On Mon, 19 Jan 2026 04:45:04 +0100,
Qin Wan wrote:
>
> This laptop uses the ALC236 codec, fixed by enabling
> the ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk
>
> Signed-off-by: Qin Wan <qin.wan@hp.com>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
The patch isn't applicable cleanly at all, as you have lots of
different quirk entries. Which git tree is it based on?
thanks,
Takashi
> ---
> sound/hda/codecs/realtek/alc269.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 0bd9fe745807..49590926199e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6704,6 +6704,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8ed8, "HP Merino16", ALC245_FIXUP_TAS2781_SPI_2),
> SND_PCI_QUIRK(0x103c, 0x8ed9, "HP Merino14W", ALC245_FIXUP_TAS2781_SPI_2),
> SND_PCI_QUIRK(0x103c, 0x8eda, "HP Merino16W", ALC245_FIXUP_TAS2781_SPI_2),
> + SND_PCI_QUIRK(0x103c, 0x8f14, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f19, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f3c, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8f3d, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8f40, "HP Lampas14", ALC287_FIXUP_TXNW2781_I2C),
> SND_PCI_QUIRK(0x103c, 0x8f41, "HP Lampas16", ALC287_FIXUP_TXNW2781_I2C),
> SND_PCI_QUIRK(0x103c, 0x8f42, "HP LampasW14", ALC287_FIXUP_TXNW2781_I2C),
> --
> 2.43.0
>
[-- Attachment #2: 0001-ALSA-hda-realtek-Fix-micmute-led-for-HP-ElitBook-6-G.patch --]
[-- Type: application/octet-stream, Size: 1625 bytes --]
From 05700cc187614e6c53a6a1d169737c4363d00728 Mon Sep 17 00:00:00 2001
From: Qin Wan <qin.wan@hp.com>
Date: Mon, 19 Jan 2026 16:39:58 +0800
Subject: [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a
Cc: stable@vger.kernel.org
Signed-off-by: Qin Wan <qin.wan@hp.com>
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
sound/hda/codecs/realtek/alc269.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 29469e549791..9f083c365489 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6813,6 +6813,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8ee7, "HP Abe A6U", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO),
SND_PCI_QUIRK(0x103c, 0x8f0c, "HP ZBook X G2i 16W", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8f0e, "HP ZBook X G2i 16W", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8f14, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8f19, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8f3c, "HP EliteBook 6 G2a 14", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8f3d, "HP EliteBook 6 G2a 16", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8f40, "HP ZBook 8 G2a 14", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x8f41, "HP ZBook 8 G2a 16", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x8f42, "HP ZBook 8 G2a 14W", ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED),
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-19 9:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-19 3:45 [PATCH] ALSA: hda/realtek: Fix micmute led for HP ElitBook 6 G2a Qin Wan
2026-01-19 6:37 ` Greg KH
2026-01-19 8:19 ` Takashi Iwai
2026-01-19 9:23 ` 回复: " Wan, Qin (Thin Client RnD)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox