From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A643350A0E; Tue, 20 Jan 2026 17:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768929539; cv=none; b=pMAtqsNqhsDpOIo0LfzLEVL8l64+FGbZwFTOPMnOtd51onRv8jpCsMCLZde2QgjEV9NwkZf6ruKoDq1wzWTQczZzBpzAu2dm0WTqcm3VTk/a0F9kaL4eYFJ/Hhg1kABAL7D3TivxnOU95foF/WXpNyE4upt8lnjamFjwti/L5Mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768929539; c=relaxed/simple; bh=e9yDWRN6uIP000lPWKUP2Jt2rEV8HOUBMGOWaexDaRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kuKVX/bqOIbcyObhez4L0wwYV2WLznWgYoVyfxiH9FkhXWy5run52pWoFeY30B62KIFHOax9dIQZ/dUIJEiHfGwux9ft5A7ayhXfl5jOeQLvTcqPaTdQ0z4s4dN04nPxn1FVeymH3mP7nKvDgPgpIl6qxxEVi9lV9gvMr2pY65k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jQ7iEYlS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jQ7iEYlS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9740FC16AAE; Tue, 20 Jan 2026 17:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768929538; bh=e9yDWRN6uIP000lPWKUP2Jt2rEV8HOUBMGOWaexDaRw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jQ7iEYlSGAjrbMLVkeK28+4oWOWdDi+lbkg9Ck4ICnuTVBzjuyeF1ncVNE2iszV94 n0DVAIaJp5/UMUMkwHPvdjoQ6g0XJZ1NG9GAQBExdm0SkU3/8y+ZOJu9qLYZ296gMt LH6WTZmRr5mAsAG/u8GHO0Ffx9E2QIJVZIPIr4T+wNCXAyzKAsI46WPED02fwi8i4A rzxk4UCW8kF7KyC6sh3n6Zo0xRqy2H7WVMy4LXA31vArDIejOeDYVQZf5SqJFKF2ZP RKDZpr0Yqc9aVuFqAseqEoGWRLXrBJ8NMk/JchKrj1rtYYMGgD3Cugav3uJckoE/8z SY6w+cibQWdYQ== Date: Tue, 20 Jan 2026 17:18:53 +0000 From: Lee Jones To: Marek Vasut Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pascal PAILLET-LME , Paul Cercueil , Sean Nyekjaer , kernel@dh-electronics.com Subject: Re: [PATCH v2] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused Message-ID: <20260120171853.GH1354723@google.com> References: <20260115173943.85764-1-marex@nabladev.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260115173943.85764-1-marex@nabladev.com> On Thu, 15 Jan 2026, Marek Vasut wrote: > Attempt to shut down again, in case the first attempt failed. > The STPMIC1 might get confused and the first regmap_update_bits() > returns with -ETIMEDOUT / -110 . If that or similar transient > failure occurs, try to shut down again. If the second attempt > fails, there is some bigger problem, report it to user. > > Cc: stable@vger.kernel.org > Fixes: 6e9df38f359a ("mfd: stpmic1: Add PMIC poweroff via sys-off handler") > Signed-off-by: Marek Vasut > --- > Cc: Lee Jones > Cc: Pascal PAILLET-LME > Cc: Paul Cercueil > Cc: Sean Nyekjaer > Cc: kernel@dh-electronics.com > --- > V2: - Use a retry loop > - Cc stable > --- > drivers/mfd/stpmic1.c | 21 ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c > index 081827bc05961..9caf2b8740829 100644 > --- a/drivers/mfd/stpmic1.c > +++ b/drivers/mfd/stpmic1.c > @@ -121,9 +121,24 @@ static const struct regmap_irq_chip stpmic1_regmap_irq_chip = { > static int stpmic1_power_off(struct sys_off_data *data) > { > struct stpmic1 *ddata = data->cb_data; > - > - regmap_update_bits(ddata->regmap, MAIN_CR, > - SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); > + int i, ret; > + > + for (i = 0; i < 2; i++) { for (int retries = 0; retries < MAX_RETIRES; retries++) > + ret = regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, > + SOFTWARE_SWITCH_OFF); > + if (!ret) > + return NOTIFY_DONE; > + > + /* > + * Attempt to shut down again, in case the first attempt failed. > + * The STPMIC1 might get confused and the first regmap_update_bits() > + * returns with -ETIMEDOUT / -110 . If that or similar transient > + * failure occurs, try to shut down again. If the second attempt > + * fails, there is some bigger problem, report it to user. > + */ > + if (i) > + dev_err(ddata->dev, "Failed to access PMIC I2C bus (%d)\n", ret); Users aren't going to care if this works on the first or second attempt. I would only issue the error once we've given up. No return error in the fail case? define NOTIFY_DONE 0x0000 /* Don't care */ Harsh! > + } > > return NOTIFY_DONE; > } > -- > 2.51.0 > -- Lee Jones [李琼斯]