public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Radhi Bajahaw <bajahawradhi@gmail.com>,
	Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
	mario.limonciello@amd.com, ravenblack@gmail.com,
	thomasmizra@gmail.com, meowmeowbeanz@gmx.com,
	yuzuru_10@proton.me, oliver.schramm97@gmail.com,
	queler@gmail.com, laodenbach@gmail.com,
	talhah.peerbhai@gmail.com, santesegabriel@gmail.com,
	alex.andries.aa@gmail.com, syed.sabakareem@amd.com
Subject: [PATCH AUTOSEL 6.18-6.6] ASoC: amd: yc: Fix microphone on ASUS M6500RE
Date: Tue, 20 Jan 2026 14:34:45 -0500	[thread overview]
Message-ID: <20260120193456.865383-2-sashal@kernel.org> (raw)
In-Reply-To: <20260120193456.865383-1-sashal@kernel.org>

From: Radhi Bajahaw <bajahawradhi@gmail.com>

[ Upstream commit 8e29db1b08808f709231e6fd4c79dcdee5b17a17 ]

Add DMI match for ASUSTeK COMPUTER INC. M6500RE to enable the
internal microphone.

Signed-off-by: Radhi Bajahaw <bajahawradhi@gmail.com>
Link: https://patch.msgid.link/20260112203814.155-1-bajahawradhi@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

## Comprehensive Analysis

### 1. COMMIT MESSAGE ANALYSIS

The commit message is clear and straightforward:
- **Subject**: "ASoC: amd: yc: Fix microphone on ASUS M6500RE"
- **Description**: Adds a DMI match for a specific ASUS laptop model to
  enable the internal microphone
- **Keywords**: "Fix" indicates this is addressing a bug (non-working
  microphone)
- **Tags**: Has proper Signed-off-by and Link tags, reviewed by Mark
  Brown (ASoC maintainer)

The commit addresses a real user-facing issue: the internal microphone
doesn't work on this specific laptop without this DMI quirk entry.

### 2. CODE CHANGE ANALYSIS

The diff shows:
- **Single file changed**: `sound/soc/amd/yc/acp6x-mach.c`
- **Change type**: Addition of a new DMI match entry to the
  `yc_acp_quirk_table[]` array
- **Lines added**: 7 lines (a new table entry)
- **Lines removed**: 0

The actual change is:
```c
{
    .driver_data = &acp6x_card,
    .matches = {
        DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
        DMI_MATCH(DMI_PRODUCT_NAME, "M6500RE"),
    }
},
```

This is identical in structure to the existing entries for other ASUS
models (M6400RC, M3402RA, M6500RC, M6501RM, E1404FA, E1504FA, etc.). The
pattern is well-established.

### 3. CLASSIFICATION

This falls squarely into the **QUIRKS and WORKAROUNDS** exception
category:
- It's a DMI-based hardware quirk for a specific laptop model
- The driver already exists and is functional
- This just adds hardware identification to enable proper audio
  configuration
- It's analogous to adding a new PCI/USB device ID to an existing driver

This is **NOT** adding a new feature - it's enabling existing
functionality on hardware that needs explicit enumeration.

### 4. SCOPE AND RISK ASSESSMENT

**Risk: VERY LOW**
- **Scope**: Extremely minimal - 7 lines added to a quirk table
- **Isolation**: The change only affects ASUS M6500RE laptops - no other
  systems are impacted
- **Pattern**: Follows exact same pattern as dozens of other entries in
  the same table
- **No logic changes**: No behavioral changes to the driver code itself
- **No dependencies**: Self-contained change

Looking at the file, there are already many ASUS laptop entries in this
table (M3402RA, M6400RC, M6500RC, M6501RM, etc.). The M6500RE is just
another variant in the same product family.

### 5. USER IMPACT

**Impact: HIGH for affected users, ZERO risk for others**
- Users with ASUS M6500RE laptops currently have non-working internal
  microphones
- This is a significant functional issue (broken audio input)
- The fix enables basic hardware functionality that users expect
- No impact whatsoever on other systems (DMI match is very specific)

### 6. STABILITY INDICATORS

- **Maintainer review**: Signed off by Mark Brown, the ASoC subsystem
  maintainer
- **Well-tested pattern**: This exact quirk table pattern has been used
  hundreds of times
- **Low complexity**: The change is purely data (no code logic)

### 7. DEPENDENCY CHECK

- **No dependencies**: This is a standalone quirk entry
- **Code exists in stable**: The `yc_acp_quirk_table` and `acp6x_card`
  have been in the kernel since the Yellow Carp (AMD Rembrandt) audio
  support was added
- **Clean backport**: Will apply cleanly to any stable tree that has
  this driver

### Summary

This commit is a textbook example of what SHOULD be backported to
stable:

1. **Fixes a real bug**: Non-working microphone on a specific laptop
2. **Obviously correct**: Follows established pattern exactly
3. **Small and contained**: 7 lines, single file, data-only change
4. **No new features**: Enables existing driver for additional hardware
5. **Zero risk of regression**: Only affects the specific ASUS M6500RE
   model
6. **Tested**: Presumably by the author who owns this hardware
7. **Maintainer approved**: Reviewed and merged by Mark Brown

This matches the "hardware quirks/workarounds" exception to the stable
rules. These DMI/PCI/USB ID additions are routinely backported because
they fix real hardware issues with essentially zero risk.

**YES**

 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index bf4d9d3365617..0294177acc663 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -416,6 +416,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "M6500RE"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.51.0


  reply	other threads:[~2026-01-20 19:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 19:34 [PATCH AUTOSEL 6.18] ALSA: usb-audio: Prevent excessive number of frames Sasha Levin
2026-01-20 19:34 ` Sasha Levin [this message]
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-5.10] ASoC: tlv320adcx140: Propagate error codes during probe Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.1] nvme-fc: release admin tagset if init fails Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18] dmaengine: mmp_pdma: Fix race condition in mmp_pdma_residue() Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-5.10] ASoC: davinci-evm: Fix reference leak in davinci_evm_probe Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.6] nvmet-tcp: fixup hang in nvmet_tcp_listen_data_ready() Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.12] ASoC: simple-card-utils: Check device node before overwrite direction Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18] ASoC: Intel: sof_sdw: Add new quirks for PTL on Dell with CS42L43 Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18] ALSA: hda/tas2781: Add newly-released HP laptop Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260120193456.865383-2-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alex.andries.aa@gmail.com \
    --cc=bajahawradhi@gmail.com \
    --cc=broonie@kernel.org \
    --cc=laodenbach@gmail.com \
    --cc=mario.limonciello@amd.com \
    --cc=meowmeowbeanz@gmx.com \
    --cc=oliver.schramm97@gmail.com \
    --cc=patches@lists.linux.dev \
    --cc=queler@gmail.com \
    --cc=ravenblack@gmail.com \
    --cc=santesegabriel@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=syed.sabakareem@amd.com \
    --cc=talhah.peerbhai@gmail.com \
    --cc=thomasmizra@gmail.com \
    --cc=yuzuru_10@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox