From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00C8A449EA0; Tue, 20 Jan 2026 19:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768937702; cv=none; b=GgsU609ypalv6xxpkuzr57KBaWcqUtJWq2725Nh4IpMOvMWV7+1dfZ3oYZe3NO4uRcte7lPMciKP4L+0LEW/OmSXnAnX9HIBwZ0H+RnejaJfCxykLjgXFdeszN3UV4qDaKGmhfAYZcjxqhS+2h/ijACa+2RE9nSvTff9Xd0c5Oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768937702; c=relaxed/simple; bh=sl0c0tXxSGUlMJVxClFDtN6MdMpzp4gx5cCUIHJzHX0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XwK1SCOSCafcwMZ7MOfxAyG7xoKewrK8VRv2JmLuziTPihRQNpBXd+JrgC973ESlSGAo5m7CMPorCmTkQCGYNY+ZPy7iNGyWsujf7rOl/rJNQYx6UlaLx5JFsxf18r0kL8FixSUL8Ribl+okyIFB7ZyvpKpJKcl676SJz5/6oac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HIZzplqa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HIZzplqa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0F51C16AAE; Tue, 20 Jan 2026 19:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768937701; bh=sl0c0tXxSGUlMJVxClFDtN6MdMpzp4gx5cCUIHJzHX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HIZzplqa9uDVBdrS9mbVmcm7D1e+m91XWVDijXUBWSH1vs9kJwmphYlP7jLZhQiPZ dWVauUUbTYEVONAn342xw0bgNuKxKpzA834zEPAc1EbSCYWf2MMv8N7yhfViunTET5 DY6MCpcJlOz3l85/++K4sL0D/fYTc3ixChKKLXys7LmQcaO4VGGMjPWhdElFeOyrVo DugbWT4l6SqZbtxIYbVtRc+KoGjGfYxe6DGRwnxorjrOJeY+GdgrrKD+zAqKG3GSXx Zit0OeBSYRbhrz3NQ1eCcBqxMjOzBkiyDHa8j/o5t9LoYSMRlsn0pZvJQG0tITZhr1 +Gfl7duD38uKw== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Radhi Bajahaw , Mark Brown , Sasha Levin , mario.limonciello@amd.com, ravenblack@gmail.com, thomasmizra@gmail.com, meowmeowbeanz@gmx.com, yuzuru_10@proton.me, oliver.schramm97@gmail.com, queler@gmail.com, laodenbach@gmail.com, talhah.peerbhai@gmail.com, santesegabriel@gmail.com, alex.andries.aa@gmail.com, syed.sabakareem@amd.com Subject: [PATCH AUTOSEL 6.18-6.6] ASoC: amd: yc: Fix microphone on ASUS M6500RE Date: Tue, 20 Jan 2026 14:34:45 -0500 Message-ID: <20260120193456.865383-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260120193456.865383-1-sashal@kernel.org> References: <20260120193456.865383-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.18.6 Content-Transfer-Encoding: 8bit From: Radhi Bajahaw [ Upstream commit 8e29db1b08808f709231e6fd4c79dcdee5b17a17 ] Add DMI match for ASUSTeK COMPUTER INC. M6500RE to enable the internal microphone. Signed-off-by: Radhi Bajahaw Link: https://patch.msgid.link/20260112203814.155-1-bajahawradhi@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: ## Comprehensive Analysis ### 1. COMMIT MESSAGE ANALYSIS The commit message is clear and straightforward: - **Subject**: "ASoC: amd: yc: Fix microphone on ASUS M6500RE" - **Description**: Adds a DMI match for a specific ASUS laptop model to enable the internal microphone - **Keywords**: "Fix" indicates this is addressing a bug (non-working microphone) - **Tags**: Has proper Signed-off-by and Link tags, reviewed by Mark Brown (ASoC maintainer) The commit addresses a real user-facing issue: the internal microphone doesn't work on this specific laptop without this DMI quirk entry. ### 2. CODE CHANGE ANALYSIS The diff shows: - **Single file changed**: `sound/soc/amd/yc/acp6x-mach.c` - **Change type**: Addition of a new DMI match entry to the `yc_acp_quirk_table[]` array - **Lines added**: 7 lines (a new table entry) - **Lines removed**: 0 The actual change is: ```c { .driver_data = &acp6x_card, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), DMI_MATCH(DMI_PRODUCT_NAME, "M6500RE"), } }, ``` This is identical in structure to the existing entries for other ASUS models (M6400RC, M3402RA, M6500RC, M6501RM, E1404FA, E1504FA, etc.). The pattern is well-established. ### 3. CLASSIFICATION This falls squarely into the **QUIRKS and WORKAROUNDS** exception category: - It's a DMI-based hardware quirk for a specific laptop model - The driver already exists and is functional - This just adds hardware identification to enable proper audio configuration - It's analogous to adding a new PCI/USB device ID to an existing driver This is **NOT** adding a new feature - it's enabling existing functionality on hardware that needs explicit enumeration. ### 4. SCOPE AND RISK ASSESSMENT **Risk: VERY LOW** - **Scope**: Extremely minimal - 7 lines added to a quirk table - **Isolation**: The change only affects ASUS M6500RE laptops - no other systems are impacted - **Pattern**: Follows exact same pattern as dozens of other entries in the same table - **No logic changes**: No behavioral changes to the driver code itself - **No dependencies**: Self-contained change Looking at the file, there are already many ASUS laptop entries in this table (M3402RA, M6400RC, M6500RC, M6501RM, etc.). The M6500RE is just another variant in the same product family. ### 5. USER IMPACT **Impact: HIGH for affected users, ZERO risk for others** - Users with ASUS M6500RE laptops currently have non-working internal microphones - This is a significant functional issue (broken audio input) - The fix enables basic hardware functionality that users expect - No impact whatsoever on other systems (DMI match is very specific) ### 6. STABILITY INDICATORS - **Maintainer review**: Signed off by Mark Brown, the ASoC subsystem maintainer - **Well-tested pattern**: This exact quirk table pattern has been used hundreds of times - **Low complexity**: The change is purely data (no code logic) ### 7. DEPENDENCY CHECK - **No dependencies**: This is a standalone quirk entry - **Code exists in stable**: The `yc_acp_quirk_table` and `acp6x_card` have been in the kernel since the Yellow Carp (AMD Rembrandt) audio support was added - **Clean backport**: Will apply cleanly to any stable tree that has this driver ### Summary This commit is a textbook example of what SHOULD be backported to stable: 1. **Fixes a real bug**: Non-working microphone on a specific laptop 2. **Obviously correct**: Follows established pattern exactly 3. **Small and contained**: 7 lines, single file, data-only change 4. **No new features**: Enables existing driver for additional hardware 5. **Zero risk of regression**: Only affects the specific ASUS M6500RE model 6. **Tested**: Presumably by the author who owns this hardware 7. **Maintainer approved**: Reviewed and merged by Mark Brown This matches the "hardware quirks/workarounds" exception to the stable rules. These DMI/PCI/USB ID additions are routinely backported because they fix real hardware issues with essentially zero risk. **YES** sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index bf4d9d3365617..0294177acc663 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -416,6 +416,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "M6500RE"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.51.0