From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Deep Harsora <Deep_Harsora@dell.com>,
Maciej Strozek <mstrozek@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com, ckeepax@opensource.cirrus.com,
mac.chiang@intel.com, rf@opensource.cirrus.com
Subject: [PATCH AUTOSEL 6.18] ASoC: Intel: sof_sdw: Add new quirks for PTL on Dell with CS42L43
Date: Tue, 20 Jan 2026 14:34:52 -0500 [thread overview]
Message-ID: <20260120193456.865383-9-sashal@kernel.org> (raw)
In-Reply-To: <20260120193456.865383-1-sashal@kernel.org>
From: Deep Harsora <Deep_Harsora@dell.com>
[ Upstream commit 12cacdfb023d1b2f6c4e5af471f2d5b6f0cbf909 ]
Add missing quirks for some new Dell laptops using cs42l43's speaker
outputs.
Signed-off-by: Deep Harsora <Deep_Harsora@dell.com>
Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
Link: https://patch.msgid.link/20260102152132.3053106-1-mstrozek@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
### SUMMARY
**What problem does this commit solve?**
- It enables audio speaker functionality on new Dell laptops (Panther
Lake platform, SKU 0DD6) using the CS42L43 codec with sidecar
amplifiers
- Without this quirk, the speakers on these specific Dell laptops won't
work properly
**Does it meet stable kernel rules?**
1. ✅ Obviously correct - follows exact same pattern as dozens of
existing entries
2. ✅ Fixes a real bug - missing hardware support (no working speakers)
3. ✅ Important issue - users can't use their laptop speakers without it
4. ✅ Small and contained - 8 lines, single file, static data only
5. ✅ No new features - uses existing quirk infrastructure
6. ✅ Applies cleanly - follows existing patterns
**Risk vs benefit trade-off:**
- **Risk**: Near zero. The quirk only matches specific Dell hardware via
DMI. Other systems are completely unaffected.
- **Benefit**: High for affected Dell users - working audio vs. broken
audio
**Concerns:**
- This can only be backported to 6.12.y stable (where
SOC_SDW_SIDECAR_AMPS exists)
- No dependencies within this commit - it's a self-contained table entry
addition
**Conclusion:**
This is a textbook example of a hardware quirk addition that should be
backported to stable. It's:
- A trivial, low-risk addition (static data in a quirk table)
- Enables hardware that wouldn't otherwise work
- Falls squarely into the "quirks and workarounds" exception category
- Follows the exact pattern of many other similar entries that have been
added for Dell/Lenovo/ASUS/Google devices
The fix is small, surgical, and meets all stable kernel criteria for the
quirk exception.
**YES**
sound/soc/intel/boards/sof_sdw.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index c013e31d098e7..92fac7ed782f7 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -750,6 +750,14 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = {
.driver_data = (void *)(SOC_SDW_CODEC_SPKR),
},
/* Pantherlake devices*/
+ {
+ .callback = sof_sdw_quirk_cb,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "0DD6")
+ },
+ .driver_data = (void *)(SOC_SDW_SIDECAR_AMPS),
+ },
{
.callback = sof_sdw_quirk_cb,
.matches = {
--
2.51.0
next prev parent reply other threads:[~2026-01-20 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 19:34 [PATCH AUTOSEL 6.18] ALSA: usb-audio: Prevent excessive number of frames Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.6] ASoC: amd: yc: Fix microphone on ASUS M6500RE Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-5.10] ASoC: tlv320adcx140: Propagate error codes during probe Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.1] nvme-fc: release admin tagset if init fails Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18] dmaengine: mmp_pdma: Fix race condition in mmp_pdma_residue() Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-5.10] ASoC: davinci-evm: Fix reference leak in davinci_evm_probe Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.6] nvmet-tcp: fixup hang in nvmet_tcp_listen_data_ready() Sasha Levin
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18-6.12] ASoC: simple-card-utils: Check device node before overwrite direction Sasha Levin
2026-01-20 19:34 ` Sasha Levin [this message]
2026-01-20 19:34 ` [PATCH AUTOSEL 6.18] ALSA: hda/tas2781: Add newly-released HP laptop Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120193456.865383-9-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Deep_Harsora@dell.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=mac.chiang@intel.com \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@lists.linux.dev \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox