From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361C73D7D8A; Wed, 21 Jan 2026 18:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769020478; cv=none; b=RsB2Pc19HHX4zn/pD002HC5wnZxhIA85359B/muxr3Gf7HSnL/um2ADjDWihhUMbVSv2uwuMJi7aTyBmuZFJx4f/CWch19nmD1lVP+NPHVAzeshkDkkRdLPFP6YyRHIA0G1ctCEaCzfrlmZLPpN7gl5ll6MOZYroUMaYuNzkolM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769020478; c=relaxed/simple; bh=2/huRtACfNCDDFE7CjJQyyeF7I5DwDOOndawQejxQe8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SjlAoG2uXKZhVcuIb3TcZhUppAVUwRWBHT80ckX4QzV6nFjmU4M006fSZo41jpt5sPOZMgQOaZ8QSXEIqdmZYo1cxIE4OyjLBnLi+a4Qsw/k670OCTag6Zn8pxsYVIDmSgOYD8nVZh4SXFI9nuXgk03qNuBzo9eSIa3FPecTc6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xA/dVZ7i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xA/dVZ7i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02884C4CEF1; Wed, 21 Jan 2026 18:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769020477; bh=2/huRtACfNCDDFE7CjJQyyeF7I5DwDOOndawQejxQe8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xA/dVZ7iQnBBW+i8OXk7AgZs2NyGpTuKSE19UZ5GwC1ryeZkCnyvAM4WOyCkvoIWW IgWsahJHOQ7zRnBXmimXDa3j4bq2aytbhXDYGS2RG0vtFPOXm0VTmLfDCmnuf0D+uQ dxouyEAVYyjpD5R5ixegnZ/Ppe0kXRz6N7eRI638= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Johan Hovold , Vinod Koul Subject: [PATCH 6.18 169/198] dmaengine: bcm-sba-raid: fix device leak on probe Date: Wed, 21 Jan 2026 19:16:37 +0100 Message-ID: <20260121181424.629274076@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260121181418.537774329@linuxfoundation.org> References: <20260121181418.537774329@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 7c3a46ebf15a9796b763a54272407fdbf945bed8 upstream. Make sure to drop the reference taken when looking up the mailbox device during probe on probe failures and on driver unbind. Fixes: 743e1c8ffe4e ("dmaengine: Add Broadcom SBA RAID driver") Cc: stable@vger.kernel.org # 4.13 Signed-off-by: Johan Hovold Link: https://patch.msgid.link/20251117161258.10679-4-johan@kernel.org Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/dma/bcm-sba-raid.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/dma/bcm-sba-raid.c +++ b/drivers/dma/bcm-sba-raid.c @@ -1699,7 +1699,7 @@ static int sba_probe(struct platform_dev /* Prealloc channel resource */ ret = sba_prealloc_channel_resources(sba); if (ret) - goto fail_free_mchan; + goto fail_put_mbox; /* Check availability of debugfs */ if (!debugfs_initialized()) @@ -1729,6 +1729,8 @@ skip_debugfs: fail_free_resources: debugfs_remove_recursive(sba->root); sba_freeup_channel_resources(sba); +fail_put_mbox: + put_device(sba->mbox_dev); fail_free_mchan: mbox_free_channel(sba->mchan); return ret; @@ -1744,6 +1746,8 @@ static void sba_remove(struct platform_d sba_freeup_channel_resources(sba); + put_device(sba->mbox_dev); + mbox_free_channel(sba->mchan); }