* [PATCH v2 1/4] PCI: dwc: Fix msg_atu_index assignment [not found] <20260122222914.523238-6-cassel@kernel.org> @ 2026-01-22 22:29 ` Niklas Cassel 2026-01-23 2:06 ` Shawn Lin 0 siblings, 1 reply; 2+ messages in thread From: Niklas Cassel @ 2026-01-22 22:29 UTC (permalink / raw) To: Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Frank Li Cc: Randolph Lin, Samuel Holland, Charles Mirabile, tim609, Krishna Chaitanya Chundru, Maciej W. Rozycki, Niklas Cassel, stable, linux-pci When dw_pcie_iatu_setup() configures outbound address translation for both type PCIE_ATU_TYPE_MEM and PCIE_ATU_TYPE_IO, the iatu index to use is incremented before calling dw_pcie_prog_outbound_atu(). However, for msg_atu_index the index is not incremented before use, causing the iATU index to be the same as the last configured iatu index, which means that it will incorrectly use the same iatu index that is already in use, breaking outbound address translation. Fixes: e1a4ec1a9520 ("PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend") Cc: stable@vger.kernel.org Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Niklas Cassel <cassel@kernel.org> --- drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index ab17549af518..cca5fc886409 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -982,7 +982,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) dev_warn(pci->dev, "Ranges exceed outbound iATU size (%d)\n", pci->num_ob_windows); - pp->msg_atu_index = i; + pp->msg_atu_index = ++i; i = 0; resource_list_for_each_entry(entry, &pp->bridge->dma_ranges) { -- 2.52.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/4] PCI: dwc: Fix msg_atu_index assignment 2026-01-22 22:29 ` [PATCH v2 1/4] PCI: dwc: Fix msg_atu_index assignment Niklas Cassel @ 2026-01-23 2:06 ` Shawn Lin 0 siblings, 0 replies; 2+ messages in thread From: Shawn Lin @ 2026-01-23 2:06 UTC (permalink / raw) To: Niklas Cassel, Jingoo Han, Manivannan Sadhasivam, Lorenzo Pieralisi, Krzysztof Wilczyński, Rob Herring, Bjorn Helgaas, Frank Li Cc: shawn.lin, Randolph Lin, Samuel Holland, Charles Mirabile, tim609, Krishna Chaitanya Chundru, Maciej W. Rozycki, stable, linux-pci 在 2026/01/23 星期五 6:29, Niklas Cassel 写道: > When dw_pcie_iatu_setup() configures outbound address translation > for both type PCIE_ATU_TYPE_MEM and PCIE_ATU_TYPE_IO, the iatu index > to use is incremented before calling dw_pcie_prog_outbound_atu(). > > However, for msg_atu_index the index is not incremented before use, > causing the iATU index to be the same as the last configured iatu > index, which means that it will incorrectly use the same iatu index > that is already in use, breaking outbound address translation. > Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com> > Fixes: e1a4ec1a9520 ("PCI: dwc: Add generic MSG TLP support for sending PME_Turn_Off when system suspend") > Cc: stable@vger.kernel.org > Reviewed-by: Frank Li <Frank.Li@nxp.com> > Signed-off-by: Niklas Cassel <cassel@kernel.org> > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index ab17549af518..cca5fc886409 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -982,7 +982,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) > dev_warn(pci->dev, "Ranges exceed outbound iATU size (%d)\n", > pci->num_ob_windows); > > - pp->msg_atu_index = i; > + pp->msg_atu_index = ++i; > > i = 0; > resource_list_for_each_entry(entry, &pp->bridge->dma_ranges) { ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-23 4:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260122222914.523238-6-cassel@kernel.org>
2026-01-22 22:29 ` [PATCH v2 1/4] PCI: dwc: Fix msg_atu_index assignment Niklas Cassel
2026-01-23 2:06 ` Shawn Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox